Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: media/filters/chunk_demuxer.cc

Issue 633243002: Log stream parsing errors in ChunkDemuxer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/chunk_demuxer.cc
diff --git a/media/filters/chunk_demuxer.cc b/media/filters/chunk_demuxer.cc
index 505d9c1f69c6a8275ad437ce23bd7374b72ffb97..64e79bf7cd3ca11ead2a1fdf2b9bfe3aab0270fb 100644
--- a/media/filters/chunk_demuxer.cc
+++ b/media/filters/chunk_demuxer.cc
@@ -330,10 +330,16 @@ bool SourceState::Append(
// TODO(wolenetz/acolwell): Curry and pass a NewBuffersCB here bound with
// append window and timestamp offset pointer. See http://crbug.com/351454.
- bool err = stream_parser_->Parse(data, length);
+ bool result = stream_parser_->Parse(data, length);
+ if (!result) {
+ DVLOG(1) << __FUNCTION__ << ": stream parsing failed."
DaleCurtis 2014/10/07 22:08:16 Is this something better sent to MEDIA_LOG() ?
+ << " Data size=" << length
+ << " append_window_start=" << append_window_start.InSecondsF()
+ << " append_window_end=" << append_window_end.InSecondsF();
+ }
timestamp_offset_during_append_ = NULL;
init_segment_received_cb_.Reset();
- return err;
+ return result;
}
void SourceState::Abort(TimeDelta append_window_start,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698