Log stream parsing errors in ChunkDemuxer

media/filters/chunk_demuxer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/chunk_demuxer.h"
 
 #include <algorithm>
 #include <limits>
 #include <list>
 
@@ skipping 312 matching lines @@
   DCHECK(!timestamp_offset_during_append_);
   DCHECK(!init_segment_received_cb.is_null());
   DCHECK(init_segment_received_cb_.is_null());
   append_window_start_during_append_ = append_window_start;
   append_window_end_during_append_ = append_window_end;
   timestamp_offset_during_append_ = timestamp_offset;
   init_segment_received_cb_= init_segment_received_cb;
 
   // TODO(wolenetz/acolwell): Curry and pass a NewBuffersCB here bound with
   // append window and timestamp offset pointer. See http://crbug.com/351454.
-  bool err = stream_parser_->Parse(data, length);
+  bool result = stream_parser_->Parse(data, length);
+  if (!result) {
+    MEDIA_LOG(log_cb_)
+        << __FUNCTION__ << ": stream parsing failed."

[wolenetz, 2014/10/07 22:50:48]

How does it look in chrome://media-internals when such a failure occurs? Is
inclusion of __FUNCTION__ too much detail?

+        << " Data size=" << length
+        << " append_window_start=" << append_window_start.InSecondsF()
+        << " append_window_end=" << append_window_end.InSecondsF();
+  }
   timestamp_offset_during_append_ = NULL;
   init_segment_received_cb_.Reset();
-  return err;
+  return result;
 }
 
 void SourceState::Abort(TimeDelta append_window_start,
                         TimeDelta append_window_end,
                         base::TimeDelta* timestamp_offset) {
   DCHECK(timestamp_offset);
   DCHECK(!timestamp_offset_during_append_);
   timestamp_offset_during_append_ = timestamp_offset;
   append_window_start_during_append_ = append_window_start;
   append_window_end_during_append_ = append_window_end;
@@ skipping 1447 matching lines @@
 }
 
 void ChunkDemuxer::ShutdownAllStreams() {
   for (SourceStateMap::iterator itr = source_state_map_.begin();
        itr != source_state_map_.end(); ++itr) {
     itr->second->Shutdown();
   }
 }
 
 }  // namespace media