Lock only permitted where a supervised user is or was.

Lock only when there is at least one supervised user on the machine.

BUG=420746
Committed: https://crrev.com/677ec3adaec076f5e41cee4f144459a77d677afc
Cr-Commit-Position: refs/heads/master@{#302412}

[Mike Lerman, 2014-10-07 20:48:43]

mlerman@chromium.org changed reviewers:
+ noms@chromium.org

[Mike Lerman, 2014-10-07 20:48:44]

Hi Monica,

Can you review this CL, please?

The changes I need to made to the ProfileInfoCache go most easily in there, but
if need be I can put them elsewhere (either doing a poll in IsLockAvailable or
having some function Observe the ProfileInfoCache for me). Let me know, thanks!

Mike

[noms (inactive), 2014-10-08 14:31:51]

Also, as discussed offline, I think we should consider removing the Lock option
if the last supervised user goes away.

https://codereview.chromium.org/633233002/diff/1/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/633233002/diff/1/chrome/common/pref_names.cc#...
chrome/common/pref_names.cc:1188: // Whether this browser has or hadat least one
supervised user.
nit: typo

[Mike Lerman, 2014-10-10 18:12:58]

Patchset #3 (id:50002) has been deleted

[Mike Lerman, 2014-10-10 18:25:02]

Patchset #3 (id:80001) has been deleted

[Mike Lerman, 2014-10-10 18:25:55]

Hi Monica,

John's comment https://code.google.com/p/chromium/issues/detail?id=420746#c8
states that lock will only be available if there are supervised users; remove
them and lock goes away.

Changed this CL to reflect that. Please re-review!

https://codereview.chromium.org/633233002/diff/1/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/633233002/diff/1/chrome/common/pref_names.cc#...
chrome/common/pref_names.cc:1188: // Whether this browser has or hadat least one
supervised user.
On 2014/10/08 14:31:51, Monica Dinculescu wrote:
> nit: typo

Thi code is removed.

[noms (inactive), 2014-10-14 14:22:01]

https://codereview.chromium.org/633233002/diff/110001/chrome/browser/profiles...
File chrome/browser/profiles/profile_window.cc (right):

https://codereview.chromium.org/633233002/diff/110001/chrome/browser/profiles...
chrome/browser/profiles/profile_window.cc:330: num_supervised_profiles++;
nit: you can just return true here, and return false at the end. You don't
actually have to count all the profiles :)

[Mike Lerman, 2014-10-29 15:28:48]

https://codereview.chromium.org/633233002/diff/110001/chrome/browser/profiles...
File chrome/browser/profiles/profile_window.cc (right):

https://codereview.chromium.org/633233002/diff/110001/chrome/browser/profiles...
chrome/browser/profiles/profile_window.cc:330: num_supervised_profiles++;
On 2014/10/14 14:22:01, Monica Dinculescu wrote:
> nit: you can just return true here, and return false at the end. You don't
> actually have to count all the profiles :)

Done.

[noms (inactive), 2014-10-29 15:58:14]

LGTM!

[Mike Lerman, 2014-10-30 18:23:23]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-10-30 18:24:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633233002/150001

[commit-bot: I haz the power, 2014-10-30 20:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 20:05:58]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mike Lerman, 2014-10-30 20:33:52]

mlerman@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Mike Lerman, 2014-10-30 20:33:53]

Hi Alexei,

Can you review this cocoa unit test change for me, please?

Thanks!
Mike

[Alexei Svitkine (slow), 2014-10-31 17:13:11]

lgtm % comments

https://codereview.chromium.org/633233002/diff/170001/chrome/browser/profiles...
File chrome/browser/profiles/profile_window.cc (right):

https://codereview.chromium.org/633233002/diff/170001/chrome/browser/profiles...
chrome/browser/profiles/profile_window.cc:319: hosted_domain != "google.com") {
This should probably have a comment about why we're hardcoding google.com here.

https://codereview.chromium.org/633233002/diff/170001/chrome/browser/profiles...
chrome/browser/profiles/profile_window.cc:324:
&g_browser_process->profile_manager()->GetProfileInfoCache();
Can you use "const ProfileInfoCache&" instead?

[Mike Lerman, 2014-11-03 03:29:09]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-11-03 03:30:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633233002/210001

[commit-bot: I haz the power, 2014-11-03 04:10:13]

Committed patchset #7 (id:210001)

[commit-bot: I haz the power, 2014-11-03 04:11:49]

Patchset 7 (id:??) landed as
https://crrev.com/677ec3adaec076f5e41cee4f144459a77d677afc
Cr-Commit-Position: refs/heads/master@{#302412}