Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 633183002: Implement C path functions (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Implement C path functions Mainly just to familiarize myself with this code. Committed: https://skia.googlesource.com/skia/+/a624e87e8e10fd9dc3a34e498dd30804ceee5228

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed unused entry point #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M experimental/sk_surface.h View 1 chunk +3 lines, -2 lines 0 comments Download
M experimental/sk_surface.cpp View 1 3 chunks +39 lines, -0 lines 0 comments Download
M gyp/experimental.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
robertphillips
https://codereview.chromium.org/633183002/diff/1/experimental/sk_surface.cpp File experimental/sk_surface.cpp (right): https://codereview.chromium.org/633183002/diff/1/experimental/sk_surface.cpp#newcode190 experimental/sk_surface.cpp:190: It seems a bit funky to call this delete ...
6 years, 2 months ago (2014-10-07 18:20:10 UTC) #2
robertphillips
ping
6 years, 2 months ago (2014-10-08 11:55:36 UTC) #3
reed1
lgtm w/ questions https://codereview.chromium.org/633183002/diff/1/experimental/sk_surface.cpp File experimental/sk_surface.cpp (right): https://codereview.chromium.org/633183002/diff/1/experimental/sk_surface.cpp#newcode34 experimental/sk_surface.cpp:34: static const SkPath* as_path(const sk_path_t* cpath) ...
6 years, 2 months ago (2014-10-08 12:12:46 UTC) #4
robertphillips
https://codereview.chromium.org/633183002/diff/1/experimental/sk_surface.cpp File experimental/sk_surface.cpp (right): https://codereview.chromium.org/633183002/diff/1/experimental/sk_surface.cpp#newcode34 experimental/sk_surface.cpp:34: static const SkPath* as_path(const sk_path_t* cpath) { Apparently it ...
6 years, 2 months ago (2014-10-08 12:56:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633183002/20001
6 years, 2 months ago (2014-10-08 12:56:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 13:04:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as a624e87e8e10fd9dc3a34e498dd30804ceee5228

Powered by Google App Engine
This is Rietveld 408576698