Simplify MinidumpModuleWriter’s module name requirement implementation

minidump/minidump_module_writer.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 232 matching lines @@
                                                uint32_t file_flags_mask) {
   DCHECK_EQ(state(), kStateMutable);
   DCHECK_EQ(file_flags & ~file_flags_mask, 0u);
 
   module_.VersionInfo.dwFileFlags = file_flags;
   module_.VersionInfo.dwFileFlagsMask = file_flags_mask;
 }
 
 bool MinidumpModuleWriter::Freeze() {
   DCHECK_EQ(state(), kStateMutable);
+  CHECK(name_);
 
   if (!MinidumpWritable::Freeze()) {
     return false;
   }
 
-  CHECK(name_);
-
   name_->RegisterRVA(&module_.ModuleNameRva);
 
   if (codeview_record_) {
     codeview_record_->RegisterLocationDescriptor(&module_.CvRecord);
   }
 
   if (misc_debug_record_) {
     misc_debug_record_->RegisterLocationDescriptor(&module_.MiscRecord);
   }
 
   return true;
 }
 
 size_t MinidumpModuleWriter::SizeOfObject() {
   DCHECK_GE(state(), kStateFrozen);
 
   // This object doesn’t directly write anything itself. Its MINIDUMP_MODULE is
   // written by its parent as part of a MINIDUMP_MODULE_LIST, and its children
   // are responsible for writing themselves.
   return 0;
 }
 
 std::vector<internal::MinidumpWritable*> MinidumpModuleWriter::Children() {
   DCHECK_GE(state(), kStateFrozen);
+  DCHECK(name_);
 
   std::vector<MinidumpWritable*> children;
-  if (name_) {
-    children.push_back(name_.get());
-  }
+  children.push_back(name_.get());
   if (codeview_record_) {
     children.push_back(codeview_record_);
   }
   if (misc_debug_record_) {
     children.push_back(misc_debug_record_);
   }
 
   return children;
 }
 
@@ skipping 67 matching lines @@
   }
 
   return file_writer->WriteIoVec(&iovecs);
 }
 
 MinidumpStreamType MinidumpModuleListWriter::StreamType() const {
   return kMinidumpStreamTypeModuleList;
 }
 
 }  // namespace crashpad