Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 633153002: cascade target fix and common test (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/completion_test_util.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart
index 9666dffc0695c046ad5633766ea87f3f39e687c4..7b732eccd7b580814fe98c48060b82309d20f598 100644
--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart
+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart
@@ -397,6 +397,7 @@ class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
}
test_Block() {
+ // Block BlockFunctionBody MethodDeclaration
addSource('/testAB.dart', '''
class A {int x;}
class _B { }''');
@@ -445,6 +446,7 @@ class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
}
test_CascadeExpression_selector1() {
+ // PropertyAccess CascadeExpression ExpressionStatement Block
addSource('/testB.dart', '''
class B { }''');
addTestSource('''
@@ -467,6 +469,7 @@ class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
}
test_CascadeExpression_selector2() {
+ // SimpleIdentifier PropertyAccess CascadeExpression ExpressionStatement
addSource('/testB.dart', '''
class B { }''');
addTestSource('''
@@ -475,7 +478,6 @@ class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
class X{}
main() {A a; a..^z}''');
computeFast();
- assertNoSuggestions();
return computeFull(true).then((_) {
assertSuggestInvocationGetter('b', null);
assertSuggestInvocationGetter('_c', 'X');
@@ -486,4 +488,21 @@ class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
assertNotSuggested('z');
});
}
+
+ test_CascadeExpression_target() {
+ // SimpleIdentifier CascadeExpression ExpressionStatement
+ addTestSource('''
+ class A {var b; X _c;}
+ class X{}
+ main() {A a; a^..b}''');
+ computeFast();
+ return computeFull(true).then((_) {
+ assertNotSuggested('b');
+ assertNotSuggested('_c');
+ assertSuggestLocalVariable('a', 'A');
+ assertSuggestLocalClass('A');
+ assertSuggestLocalClass('X');
+ assertSuggestImportedClass('Object');
+ });
+ }
}

Powered by Google App Engine
This is Rietveld 408576698