Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 633123002: [turbofan] Add support for ARM64 Ubfx (Closed)

Created:
6 years, 2 months ago by m.m.capewell
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for ARM64 Ubfx Support selecting Ubfx for shift-mask and mask-shift operations. Also, rename the shifts to match the instruction names. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24482

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix bit counting and random functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -30 lines) Patch
M src/base/bits.h View 1 4 chunks +50 lines, -6 lines 0 comments Download
M src/base/utils/random-number-generator.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/base/utils/random-number-generator.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +8 lines, -6 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 3 chunks +90 lines, -6 lines 0 comments Download
M test/unittests/base/bits-unittest.cc View 3 chunks +37 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 2 chunks +144 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
m.m.capewell
6 years, 2 months ago (2014-10-08 09:25:07 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/633123002/diff/1/src/base/bits.h File src/base/bits.h (right): https://codereview.chromium.org/633123002/diff/1/src/base/bits.h#newcode107 src/base/bits.h:107: inline uint64_t CountTrailingZeros64(uint64_t value) { I think the result ...
6 years, 2 months ago (2014-10-08 11:40:12 UTC) #3
m.m.capewell
https://codereview.chromium.org/633123002/diff/1/src/base/bits.h File src/base/bits.h (right): https://codereview.chromium.org/633123002/diff/1/src/base/bits.h#newcode107 src/base/bits.h:107: inline uint64_t CountTrailingZeros64(uint64_t value) { On 2014/10/08 11:40:12, Benedikt ...
6 years, 2 months ago (2014-10-08 17:35:02 UTC) #4
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-09 06:11:43 UTC) #5
Benedikt Meurer
6 years, 2 months ago (2014-10-09 09:18:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698