Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 633093002: Returns nullptr in getImageSourceForCanvas when imageSnapshot is null (Closed)

Created:
6 years, 2 months ago by Rémi Piotaix
Modified:
6 years, 2 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Returns nullptr in getImageSourceForCanvas when imageSnapshot is null BUG=421033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Rémi Piotaix
PTAL
6 years, 2 months ago (2014-10-07 15:29:39 UTC) #2
Justin Novosad
On 2014/10/07 15:29:39, Rémi Piotaix wrote: > PTAL lgtm
6 years, 2 months ago (2014-10-10 17:50:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633093002/1
6 years, 2 months ago (2014-10-10 17:51:59 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 21:43:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183554

Powered by Google App Engine
This is Rietveld 408576698