Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Issue 633053002: Do not save/restore AST id generator. (Closed)

Created:
6 years, 2 months ago by Sven Panne
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Do not save/restore AST id generator. AST ids only need to be unique, so there is no need to fiddle around with them. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -37 lines) Patch
M src/parser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parser.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/preparser.h View 5 chunks +5 lines, -9 lines 0 comments Download
M src/preparser.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sven Panne
6 years, 2 months ago (2014-10-07 12:14:53 UTC) #2
Dmitry Lomov (no reviews)
lgtm!
6 years, 2 months ago (2014-10-07 12:15:52 UTC) #3
Sven Panne
Committed patchset #1 (id:1) manually as 24433 (presubmit successful).
6 years, 2 months ago (2014-10-07 12:16:39 UTC) #4
wingo
6 years, 2 months ago (2014-10-07 13:03:47 UTC) #5
Message was sent while issue was closed.
Great!  One fewer thing to futz when destructuring.

Powered by Google App Engine
This is Rietveld 408576698