ui/accessibility/platform/ax_platform_node_mac.mm - Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/accessibility/platform/ax_platform_node_mac.mm

Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding expectations for mac and android Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/accessibility/platform/ax_platform_node_mac.mm

diff --git a/ui/accessibility/platform/ax_platform_node_mac.mm b/ui/accessibility/platform/ax_platform_node_mac.mm

index 8f0708ddb9e0a832d5da2f452f590836c965a9ed..7431c6b302647011aad8bb60677794275347f9ee 100644

--- a/ui/accessibility/platform/ax_platform_node_mac.mm

+++ b/ui/accessibility/platform/ax_platform_node_mac.mm

@@ -83,6 +83,8 @@ RoleMap BuildRoleMap() {

{ui::AX_ROLE_MENU_BAR, NSAccessibilityMenuBarRole},

{ui::AX_ROLE_MENU_BUTTON, NSAccessibilityButtonRole},

{ui::AX_ROLE_MENU_ITEM, NSAccessibilityMenuItemRole},

+ {ui::AX_ROLE_MENU_ITEM_CHECK_BOX, NSAccessibilityMenuItemRole},

+ {ui::AX_ROLE_MENU_ITEM_RADIO, NSAccessibilityMenuItemRole},

{ui::AX_ROLE_MENU_LIST_OPTION, NSAccessibilityMenuItemRole},

{ui::AX_ROLE_MENU_LIST_POPUP, NSAccessibilityUnknownRole},

{ui::AX_ROLE_NAVIGATION, NSAccessibilityGroupRole},

« content/test/data/accessibility/aria-menuitemcheckbox-expected-mac.txt ('K') | « ui/accessibility/ax_enums.idl ('k') | no next file » | no next file with comments »