Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 633033002: Replace OVERRIDE with override in WebKit/public (Closed)

Created:
6 years, 2 months ago by Vartul
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
blink-reviews, jamesr, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace OVERRIDE with override in WebKit/public BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183381

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M public/platform/WebFederatedCredential.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebLocalCredential.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Vartul
Please review. Thanks!
6 years, 2 months ago (2014-10-07 10:02:49 UTC) #2
jamesr
This code doesn't use FINAL or final from what I can tell. Please fix the ...
6 years, 2 months ago (2014-10-07 19:37:55 UTC) #3
Vartul
On 2014/10/07 19:37:55, jamesr wrote: > This code doesn't use FINAL or final from what ...
6 years, 2 months ago (2014-10-08 02:51:45 UTC) #4
jamesr
lgtm
6 years, 2 months ago (2014-10-08 03:12:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633033002/1
6 years, 2 months ago (2014-10-08 03:41:16 UTC) #7
commit-bot: I haz the power
Failed to apply patch for public/web/WebMIDIClientMock.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-08 03:41:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633033002/20001
6 years, 2 months ago (2014-10-08 04:00:21 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 05:01:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183381

Powered by Google App Engine
This is Rietveld 408576698