Cookie commands for the webdriver protocol

chrome/test/webdriver/automation.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_WEBDRIVER_AUTOMATION_H_
 #define CHROME_TEST_WEBDRIVER_AUTOMATION_H_
 
 #include <string>
 
 #include "base/task.h"
@@ skipping 24 matching lines @@
   void ExecuteScript(const std::string& frame_xpath,
                      const std::string& script,
                      std::string* result,
                      bool* success);
 
   void NavigateToURL(const std::string& url, bool* success);
   void GoForward(bool* success);
   void GoBack(bool* success);
   void Reload(bool* success);
   void GetURL(std::string* url, bool* success);
+  void GetGURL(GURL* gurl, bool* success);
   void GetTabTitle(std::string* tab_title, bool* success);
+  void GetCookies(const GURL& gurl, std::string* cookies, bool* success);

[John Grabowski, 2011/02/14 21:59:06]

Why don't you like return values?
Seems you could have all these methods return the success bool.  

[kkania, 2011/02/14 22:47:08]

We don't return bool because these methods are called by posting a
NewRunnableMethod task on the session thread. See session.cc. Alternative:

Session::GetCookies(...) {
  session_thread->PostTask(NewRunnableMethod(&Session::GetCookiesOnSThread))
}

Session::GetCookiesOnSThread(bool* success) {
*success = automation->GetCookies(...)
}

bool Automation::GetCookies(...) { ... }

I do not think it is worthwhile to adopt this alternative, as it requires
writing an extra wrapper in Session. Please let me know if you think otherwise.

[John Grabowski, 2011/02/14 22:57:09]

Seems completely reasonable.
How about a comment at the class declaration stating as such?  

+  void GetCookieByName(const GURL& gurl, const std::string& cookie_name,
+                       std::string* cookie, bool* success);
+  void DeleteCookie(const GURL& gurl, const std::string& cookie_name,
+                    bool* success);
+  void SetCookie(const GURL& gurl, const std::string& cookie, bool* success);
 
  private:
   scoped_refptr<BrowserProxy> browser_;
   scoped_refptr<TabProxy> tab_;
 
   ScopedTempDir profile_dir_;
 
   DISALLOW_COPY_AND_ASSIGN(Automation);
 };
 
 }  // namespace webdriver
 
 DISABLE_RUNNABLE_METHOD_REFCOUNT(webdriver::Automation);
 
 #endif  // CHROME_TEST_WEBDRIVER_AUTOMATION_H_