Issue 632903003: Remove unnecessary isolate TLS from compiler jobs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 632903003: Remove unnecessary isolate TLS from compiler jobs (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 2 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove unnecessary isolate TLS from compiler jobs BUG=none R=yangguo@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=24430

Patch Set 2 : updaes #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	src/optimizing-compiler-thread.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM. https://codereview.chromium.org/632903003/diff/1/src/optimizing-compiler-thread.cc File src/optimizing-compiler-thread.cc (right): https://codereview.chromium.org/632903003/diff/1/src/optimizing-compiler-thread.cc#newcode81 src/optimizing-compiler-thread.cc:81: Isolate::SetIsolateThreadLocals(isolate_, NULL); We can probably also do it ...

6 years, 2 months ago (2014-10-07 09:50:02 UTC) #2

jochen (gone - plz use gerrit)

6 years, 2 months ago (2014-10-07 09:54:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24430 (presubmit successful).

Expand Messages | Collapse Messages

Issue 632903003: Remove unnecessary isolate TLS from compiler jobs (Closed)

Description

Patch Set 1 #

Patch Set 2 : updaes #

Messages