Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 632873002: Remove implicit conversions from scoped_refptr to T* in net/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
szym
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in net/ This patch was generated by running the rewrite_scoped_refptr clang tool on an Android build. BUG=110610 Committed: https://crrev.com/0eb8b4f58a683620917fb3d71a91504ebecd7922 Cr-Commit-Position: refs/heads/master@{#298434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/cert/cert_verify_proc_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
6 years, 2 months ago (2014-10-06 22:42:50 UTC) #2
szym
lgtm
6 years, 2 months ago (2014-10-07 02:21:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632873002/1
6 years, 2 months ago (2014-10-07 02:59:34 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 05:02:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632873002/1
6 years, 2 months ago (2014-10-07 10:07:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as b591d61b3c7a9720b05e0d8641c9b90ad26df09b
6 years, 2 months ago (2014-10-07 10:08:09 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 10:08:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0eb8b4f58a683620917fb3d71a91504ebecd7922
Cr-Commit-Position: refs/heads/master@{#298434}

Powered by Google App Engine
This is Rietveld 408576698