Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 632853002: Define gyp targets for mojo/public/* in mojo/public/mojo_public.gyp (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Define gyp targets for mojo/public/* in mojo/public/mojo_public.gyp The targets in the mojo public SDK, i.e. those in mojo/public/, should be free of dependencies outside of mojo/public/ and usable in a standalone fashion. This moves the gyp definitions from mojo/mojo_base.gyp, which also contains a number of non-public targets, to mojo/public/mojo_public.gyp. R=viettrungluu@chromium.org TBR=darin@chromium.org for updating various gyp entries to point to new target location Committed: https://crrev.com/b83f9dcb4940d4700632fe9e925abec779ad84ef Cr-Commit-Position: refs/heads/master@{#298422}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix up BUILD.gn crossrefs and pseudo targets #

Patch Set 4 : fix android and ios builds #

Patch Set 5 : ios fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+674 lines, -669 lines) Patch
M build/all.gyp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M content/content_child.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_common_mojo_bindings.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M content/content_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_plugin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M content/content_utility.gypi View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M media/media.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/mojo.gyp View 1 2 10 chunks +17 lines, -16 lines 0 comments Download
M mojo/mojo_apps.gypi View 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 11 chunks +139 lines, -24 lines 0 comments Download
M mojo/mojo_examples.gypi View 21 chunks +47 lines, -47 lines 0 comments Download
D mojo/mojo_public.gypi View 1 chunk +0 lines, -257 lines 0 comments Download
D mojo/mojo_public_tests.gypi View 1 chunk +0 lines, -217 lines 0 comments Download
M mojo/mojo_services.gypi View 19 chunks +44 lines, -44 lines 0 comments Download
M mojo/mojo_variables.gypi View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/public/c/system/tests/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/test_support/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/tests/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/tests/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/tests/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/test_support/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/utility/tests/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/application/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
A mojo/public/mojo_public.gyp View 1 2 3 1 chunk +363 lines, -0 lines 0 comments Download
M mojo/public/platform/native/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jamesr
vtl@ - please review darin@ - please stamp for top-level OWNERS
6 years, 2 months ago (2014-10-06 22:36:15 UTC) #2
viettrungluu
LGTM as far as I can tell (which isn't very far).
6 years, 2 months ago (2014-10-06 22:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632853002/60001
6 years, 2 months ago (2014-10-07 06:43:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/21700)
6 years, 2 months ago (2014-10-07 06:48:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632853002/80001
6 years, 2 months ago (2014-10-07 06:52:47 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001) as eed7fbf9371f1aa54cba75e50bf79cd581774916
6 years, 2 months ago (2014-10-07 08:04:18 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 08:05:06 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b83f9dcb4940d4700632fe9e925abec779ad84ef
Cr-Commit-Position: refs/heads/master@{#298422}

Powered by Google App Engine
This is Rietveld 408576698