Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: net/proxy/proxy_config_service_win.h

Issue 632833002: Remove raw handles from base::win::RegKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove XP specific code. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/dns_config_service_win.cc ('k') | net/proxy/proxy_config_service_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_config_service_win.h
diff --git a/net/proxy/proxy_config_service_win.h b/net/proxy/proxy_config_service_win.h
index 62f1f120c74c265f40a64b3ed98aedb522751bf1..52c389574d4056862aedb7d3543e594be45b77be 100644
--- a/net/proxy/proxy_config_service_win.h
+++ b/net/proxy/proxy_config_service_win.h
@@ -12,9 +12,14 @@
#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h"
-#include "base/win/object_watcher.h"
#include "net/proxy/polling_proxy_config_service.h"
+namespace base {
+namespace win {
+class RegKey;
+}
+} // namespace base.
+
namespace net {
// Implementation of ProxyConfigService that retrieves the system proxy
@@ -40,8 +45,7 @@ namespace net {
// change, or in case we got it wrong (and are not checking all possible
// registry dependencies).
class NET_EXPORT_PRIVATE ProxyConfigServiceWin
- : public PollingProxyConfigService,
- public base::win::ObjectWatcher::Delegate {
+ : public PollingProxyConfigService {
public:
ProxyConfigServiceWin();
virtual ~ProxyConfigServiceWin();
@@ -51,19 +55,17 @@ class NET_EXPORT_PRIVATE ProxyConfigServiceWin
private:
FRIEND_TEST_ALL_PREFIXES(ProxyConfigServiceWinTest, SetFromIEConfig);
- class KeyEntry;
- typedef std::vector<KeyEntry*> KeyEntryList;
+ typedef std::vector<base::win::RegKey*> RegKeyList;
// Registers change observers on the registry keys relating to proxy settings.
void StartWatchingRegistryForChanges();
- // Creates a new KeyEntry and appends it to |keys_to_watch_|. If the key
- // fails to be created, it is not appended to the list and we return false.
+ // Creates a new key and appends it to |keys_to_watch_|. If the key fails to
+ // be created, it is not appended to the list and we return false.
bool AddKeyToWatchList(HKEY rootkey, const wchar_t* subkey);
- // ObjectWatcher::Delegate methods:
// This is called whenever one of the registry keys we are watching change.
- virtual void OnObjectSignaled(HANDLE object) override;
+ void OnObjectSignaled(base::win::RegKey* key);
static void GetCurrentProxyConfig(ProxyConfig* config);
@@ -72,7 +74,7 @@ class NET_EXPORT_PRIVATE ProxyConfigServiceWin
ProxyConfig* config,
const WINHTTP_CURRENT_USER_IE_PROXY_CONFIG& ie_config);
- KeyEntryList keys_to_watch_;
+ RegKeyList keys_to_watch_;
};
} // namespace net
« no previous file with comments | « net/dns/dns_config_service_win.cc ('k') | net/proxy/proxy_config_service_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698