Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 6328009: Move swapping of operands for commutative binary operations to the lithium IR...

Created:
9 years, 11 months ago by fschneider
Modified:
9 years, 11 months ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

Move swapping of operands for commutative binary operations to the lithium IR. There is no reason to have this helper functions already at the hydrogen level. At the hydrogen level commutativity depends on the representation type and the information is only used to swap the operands when we can emit an immediate operand in the code generator.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -41 lines) Patch
M src/arm/lithium-arm.cc View 3 chunks +18 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +0 lines, -27 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +18 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
fschneider
9 years, 11 months ago (2011-01-25 12:40:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698