Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1380)

Issue 632793002: Docs: devtools extensions. Messaging flow from inject script to devtools (Closed)

Created:
6 years, 2 months ago by paulirish
Modified:
6 years, 2 months ago
Base URL:
https://chromium.googlesource.com/chromium/src@master
Visibility:
Public.

Description

Docs: devtools extensions. Messaging flow from inject script to devtools Patch authored by: Thomas Boyt http://www.thomasboyt.com/2014/10/06/chrome-message-workaround.html BUG= Committed: https://crrev.com/094e637503ebe258c4c94f67bd45939f9fbf51bd Cr-Commit-Position: refs/heads/master@{#299853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M chrome/common/extensions/docs/templates/articles/devtools.html View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
paulirish
PTAL
6 years, 2 months ago (2014-10-06 19:44:28 UTC) #2
paulirish
Can I get your review?
6 years, 2 months ago (2014-10-07 21:14:28 UTC) #4
paulirish
Can I get your review?
6 years, 2 months ago (2014-10-07 21:14:29 UTC) #5
pbakaus
lgtm
6 years, 2 months ago (2014-10-08 12:00:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632793002/1
6 years, 2 months ago (2014-10-15 21:37:34 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-15 21:37:36 UTC) #10
paulirish
kalman, rubber stamp from a committer requested! :)
6 years, 2 months ago (2014-10-15 21:38:36 UTC) #12
not at google - send to devlin
lgtm
6 years, 2 months ago (2014-10-15 22:25:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632793002/1
6 years, 2 months ago (2014-10-16 05:21:36 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 05:43:32 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 05:44:15 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/094e637503ebe258c4c94f67bd45939f9fbf51bd
Cr-Commit-Position: refs/heads/master@{#299853}

Powered by Google App Engine
This is Rietveld 408576698