Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 632743004: When patching gcc specs file use existing specs if found (Closed)

Created:
6 years, 2 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
noelallen1
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Visibility:
Public.

Description

When patching gcc specs file use existing specs if found This avoids clobbering the specs file that ships with the bionic toolchain. This allows a lot more packages to build with bionic. R=noelallen@chromium.org Committed: https://chromium.googlesource.com/external/naclports/+/f24c45df98c1f2d9f8e245530131ceb6bd653ec6

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -35 lines) Patch
M build_tools/common.sh View 1 2 3 5 chunks +21 lines, -9 lines 0 comments Download
M ports/agg-demo/pkg_info View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ports/apr/build.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M ports/box2d/pkg_info View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ports/geturl/pkg_info View 1 chunk +0 lines, -1 line 0 comments Download
M ports/leveldb/nacl.patch View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M ports/leveldb/pkg_info View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ports/metakit/build.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ports/mpg123/pkg_info View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ports/nano/pkg_info View 1 1 chunk +1 line, -0 lines 0 comments Download
M ports/ncurses/pkg_info View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ports/openal-soft/pkg_info View 1 chunk +1 line, -0 lines 0 comments Download
M ports/protobuf-c/pkg_info View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ports/python/pkg_info View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ports/python3/pkg_info View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ports/readline/pkg_info View 1 chunk +0 lines, -1 line 0 comments Download
M ports/regal/pkg_info View 1 chunk +1 line, -0 lines 0 comments Download
M ports/snes9x/pkg_info View 1 chunk +0 lines, -3 lines 0 comments Download
M ports/tinyxml/pkg_info View 1 chunk +0 lines, -1 line 0 comments Download
M ports/unzip/nacl.patch View 1 chunk +1 line, -1 line 0 comments Download
M ports/unzip/pkg_info View 1 chunk +0 lines, -1 line 0 comments Download
M ports/vim/pkg_info View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sam Clegg
6 years, 2 months ago (2014-10-06 22:24:44 UTC) #2
noelallen1
A few nits, otherwise LGTM https://codereview.chromium.org/632743004/diff/40001/build_tools/common.sh File build_tools/common.sh (right): https://codereview.chromium.org/632743004/diff/40001/build_tools/common.sh#newcode302 build_tools/common.sh:302: # The emscripten compiler ...
6 years, 2 months ago (2014-10-07 18:25:03 UTC) #3
Sam Clegg
https://codereview.chromium.org/632743004/diff/40001/build_tools/common.sh File build_tools/common.sh (right): https://codereview.chromium.org/632743004/diff/40001/build_tools/common.sh#newcode302 build_tools/common.sh:302: # The emscripten compiler doesn't currently need a patched ...
6 years, 2 months ago (2014-10-07 18:34:26 UTC) #4
Sam Clegg
6 years, 2 months ago (2014-10-07 18:35:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
f24c45df98c1f2d9f8e245530131ceb6bd653ec6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698