Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 632653002: Replacing the OVERRIDE with override and FINAL with final in /src/crypto (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, MRV, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in /src/crypto This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/d1c2d2ad303bda1c49d453b460d6bbacf80240ca Cr-Commit-Position: refs/heads/master@{#298360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M crypto/ec_signature_creator_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M crypto/mock_apple_keychain.h View 4 chunks +11 lines, -11 lines 0 comments Download
M crypto/secure_hash_default.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M crypto/secure_hash_openssl.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-06 10:54:37 UTC) #2
Ryan Sleevi
lgtm
6 years, 2 months ago (2014-10-07 01:03:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632653002/1
6 years, 2 months ago (2014-10-07 01:04:11 UTC) #5
anujsharma
On 2014/10/07 01:04:11, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 2 months ago (2014-10-07 02:37:05 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 03:08:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632653002/1
6 years, 2 months ago (2014-10-07 03:29:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1b5e24f4409cccb4e21b8db7a2ecd8d9d75fbc2a
6 years, 2 months ago (2014-10-07 04:07:29 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 04:08:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1c2d2ad303bda1c49d453b460d6bbacf80240ca
Cr-Commit-Position: refs/heads/master@{#298360}

Powered by Google App Engine
This is Rietveld 408576698