Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 632613002: [C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr (Closed)

Created:
6 years, 2 months ago by ARUNKK
Modified:
6 years, 2 months ago
Reviewers:
danakj, reveman, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr BUG = Committed: https://crrev.com/289dbf8be2824a3215c4f315be1a81847c05e5a7 Cr-Commit-Position: refs/heads/master@{#298256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M cc/animation/animation_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/layer_animation_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 18 chunks +21 lines, -21 lines 0 comments Download
M cc/animation/transform_operations.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/base/latency_info_swap_promise_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/base/math_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/scoped_ptr_vector.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/scoped_ptr_vector_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/base/swap_promise_monitor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/base/tiling_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ARUNKK
reveman@chromium.org: Please review changes in piman@chromium.org: Please review changes in PTAL.
6 years, 2 months ago (2014-10-06 07:47:32 UTC) #2
danakj
LGTM
6 years, 2 months ago (2014-10-06 15:33:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632613002/1
6 years, 2 months ago (2014-10-06 15:34:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4fcb054a306509d5b70abafc9e2b85763bc5ad37
6 years, 2 months ago (2014-10-06 17:17:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 17:18:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/289dbf8be2824a3215c4f315be1a81847c05e5a7
Cr-Commit-Position: refs/heads/master@{#298256}

Powered by Google App Engine
This is Rietveld 408576698