Adding regex support to search bar in dev tools console

Source/devtools/front_end/console/ConsoleView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 21 matching lines @@
  * @extends {WebInspector.VBox}
  * @implements {WebInspector.Searchable}
  * @implements {WebInspector.TargetManager.Observer}
  * @implements {WebInspector.ViewportControl.Provider}
  */
 WebInspector.ConsoleView = function()
 {
     WebInspector.VBox.call(this);
     this.registerRequiredCSS("filter.css");
 
-    this._searchableView = new WebInspector.SearchableView(this);
+    this._searchableView = new WebInspector.SearchableView(this, true);

[robwu, 2014/10/06 08:30:21]

Why did you use true as the default setting? Plaintext search should be used by
default. See my earlier comment, I think that you should remove this new
parameter.

     this._searchableView.setMinimalSearchQuerySize(0);
     this._searchableView.show(this.element);
 
     this._contentsElement = this._searchableView.element;
     this._contentsElement.classList.add("console-view");
     this._visibleViewMessages = [];
     this._urlToMessageCount = {};
     this._hiddenByFilterCount = 0;
 
     this._clearConsoleButton = new WebInspector.StatusBarButton(WebInspector.UIString("Clear console log."), "clear-status-bar-item");
@@ skipping 853 matching lines @@
 
     /**
      * @param {string} query
      * @param {boolean} shouldJump
      * @param {boolean=} jumpBackwards
      */
     performSearch: function(query, shouldJump, jumpBackwards)
     {
         this.searchCanceled();
         this._searchableView.updateSearchMatchesCount(0);
-        this._searchRegex = createPlainTextSearchRegex(query, "gi");
+        if (!this._searchableView.enableRegex) {
+            this._searchRegex = createPlainTextSearchRegex(query, "gi");
+        }
+        else {

[robwu, 2014/10/06 08:30:21]

} else { must be on a single line.

[aknudsen, 2014/10/07 19:39:57]

Done.

+            this._searchRegex = new RegExp(query, "gi");

[robwu, 2014/10/06 08:30:22]

Use a separate function or method to construct the regex, and make sure that you
properly handle invalid regular expressions. Currently, when you pass in an
invalid regex, a SyntaxError will be thrown.

The devtools has already implemented regex filtering for console messages. You
could locate this code and see whether it can be re-used for this purpose.

[aknudsen, 2014/10/07 19:39:57]

Acknowledged.

[aknudsen, 2014/10/07 20:50:12]

Done.

+        }
 
         /** @type {!Array.<number>} */
         this._searchResults = [];
         for (var i = 0; i < this._visibleViewMessages.length; i++) {
             if (this._visibleViewMessages[i].matchesRegex(this._searchRegex))
                 this._searchResults.push(i);
         }
         this._searchableView.updateSearchMatchesCount(this._searchResults.length);
         this._currentSearchResultIndex = -1;
         if (shouldJump && this._searchResults.length)
@@ skipping 332 matching lines @@
 WebInspector.ConsoleView.ShowConsoleActionDelegate.prototype = {
     /**
      * @return {boolean}
      */
     handleAction: function()
     {
         WebInspector.console.show();
         return true;
     }
 }