sdk/lib/_internal/pub_generated/lib/src/pubspec.dart - Issue 632483002: Printing a useful error message if a version field is a num

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/pubspec.dart

Issue 632483002: Printing a useful error message if a version field is a num (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Adding pubspec bad version tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/pub/test/pubspec_test.dart ('K') | « sdk/lib/_internal/pub/test/pubspec_test.dart ('k') | sdk/lib/_internal/pub_generated/test/pubspec_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub_generated/lib/src/pubspec.dart

diff --git a/sdk/lib/_internal/pub_generated/lib/src/pubspec.dart b/sdk/lib/_internal/pub_generated/lib/src/pubspec.dart

index b8b28ed154b137d4d85339a71536410cea382528..5ab37ff54a57b77a933d7e3bc5e69be0e05ed7f2 100644

--- a/sdk/lib/_internal/pub_generated/lib/src/pubspec.dart

+++ b/sdk/lib/_internal/pub_generated/lib/src/pubspec.dart

@@ -37,6 +37,14 @@ class Pubspec {

return _version;

}

var span = fields.nodes['version'].span;

+ if (version is num) {

+ String fixed = '$version.0';

+ if (version is int) {

+ fixed = '$fixed.0';

+ }

+ _error('"version" field must have three numeric components: major, minor, '

+ 'and patch. Instead of "$version", consider "$fixed".', span);

+ }

if (version is! String) {

_error('"version" field must be a string.', span);

}