Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: sdk/lib/_internal/pub/lib/src/pubspec.dart

Issue 632483002: Printing a useful error message if a version field is a num (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Adding pubspec bad version tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/pubspec.dart
diff --git a/sdk/lib/_internal/pub/lib/src/pubspec.dart b/sdk/lib/_internal/pub/lib/src/pubspec.dart
index 55b2df7ba57935ac2744e369b76012169e6515e1..8fd9f1ddbfa13dfdaa740aa0b0ff02243c0062c2 100644
--- a/sdk/lib/_internal/pub/lib/src/pubspec.dart
+++ b/sdk/lib/_internal/pub/lib/src/pubspec.dart
@@ -74,6 +74,14 @@ class Pubspec {
}
var span = fields.nodes['version'].span;
+ if (version is num) {
+ String fixed = '$version.0';
Bob Nystrom 2014/10/06 19:21:10 We just use "var" for local variables.
srawlins 2014/10/06 19:44:16 Done.
+ if (version is int) {
+ fixed = '$fixed.0';
+ }
+ _error('"version" field must have three numeric components: major, minor, '
Bob Nystrom 2014/10/06 19:21:10 Still just slightly too long. :)
srawlins 2014/10/06 19:44:16 Done.
+ 'and patch. Instead of "$version", consider "$fixed".', span);
+ }
if (version is! String) {
_error('"version" field must be a string.', span);
}
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/test/pubspec_test.dart » ('j') | sdk/lib/_internal/pub/test/pubspec_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698