local cascade suggestion fix and move towards common tests

pkg/analysis_server/test/services/completion/imported_computer_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.toplevel;
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/imported_computer.dart';
 import 'package:unittest/unittest.dart';
 
 import '../../reflective_tests.dart';
 import 'completion_test_util.dart';
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(ImportedTypeComputerTest);
 }
 
 @ReflectiveTestCase()
-class ImportedTypeComputerTest extends AbstractCompletionTest {
+class ImportedTypeComputerTest extends AbstractSelectorSuggestionTest {
 
   @override
   void setUp() {
     super.setUp();
     computer = new ImportedComputer();
   }
 
-  test_Block_class() {
-    // Block  BlockFunctionBody  MethodDeclaration  ClassDeclaration
-    addSource('/testAB.dart', '''
-      class A {int x;}
-      class _B { }''');
-    addSource('/testCD.dart', '''
-      class C { }
-      class D { }''');
-    addSource('/testEEF.dart', '''
-      class EE { }
-      class F { }''');
-    addSource('/testG.dart', 'class G { }');
-    addSource('/testH.dart', 'class H { }'); // not imported
-    addTestSource('''
-      import "/testAB.dart";
-      import "/testCD.dart" hide D;
-      import "/testEEF.dart" show EE;
-      import "/testG.dart" as g;
-      class X {foo(){^}}''');
-    // pass true for full analysis to pick up unimported source
-    return computeFull(true).then((_) {
-      assertSuggestClass('A');
-      assertNotSuggested('x');
-      assertNotSuggested('_B');
-      assertSuggestClass('C');
-      // hidden element suggested as low relevance
-      assertSuggestClass('D', CompletionRelevance.LOW);
-      assertSuggestClass('EE');
-      // hidden element suggested as low relevance
-      assertSuggestClass('F', CompletionRelevance.LOW);
-      assertSuggestLibraryPrefix('g');
-      assertNotSuggested('G');
-      assertSuggestClass('H', CompletionRelevance.LOW);
-      // Should not suggest compilation unit elements
-      // which are returned by the LocalComputer
-      assertNotSuggested('X');
-      assertSuggestClass('Object');
-      // TODO (danrubel) suggest HtmlElement as low relevance
-      assertNotSuggested('HtmlElement');
-    });
-  }
-
   test_Block_function() {
     // Block  BlockFunctionBody  MethodDeclaration  ClassDeclaration
     addSource('/testA.dart', '''
       export "dart:math" hide max;
       @deprecated A() {int x;}
       _B() {}''');
     addTestSource('''
       import "/testA.dart";
       class X {foo(){^}}''');
     return computeFull().then((_) {
@@ skipping 25 matching lines @@
       assertSuggestTopLevelVarGetterSetter('T1', 'String');
       assertNotSuggested('_T2');
       assertSuggestTopLevelVar('T3', 'int', CompletionRelevance.LOW);
       assertNotSuggested('_T4');
       // LocalComputer provides local suggestions
       assertNotSuggested('C');
       assertNotSuggested('foo');
     });
   }
 
+  test_ConstructorName_importedClass() {
+    // SimpleIdentifier  PrefixedIdentifier  TypeName  ConstructorName
+    // InstanceCreationExpression
+    addSource('/testB.dart', '''
+      lib B;
+      class X {X.c(); X._d(); z() {}}''');
+    addTestSource('''
+      import "/testB.dart";
+      var m;
+      main() {new X.^}''');
+    return computeFull().then((_) {
+      assertNoSuggestions();
+    });
+  }
+
+  test_ConstructorName_localClass() {
+    // SimpleIdentifier  PrefixedIdentifier  TypeName  ConstructorName
+    // InstanceCreationExpression
+    addTestSource('''
+      var m;
+      class X {X.c(); X._d(); z() {}}
+      main() {new X.^}''');
+    return computeFull().then((_) {
+      assertNoSuggestions();
+    });
+  }
+
   test_ExpressionStatement_class() {
     // SimpleIdentifier  ExpressionStatement  Block
     addSource('/testA.dart', '''
       class A {int x;}
       class _B { }''');
     addTestSource('''
       import "/testA.dart";
       class C {foo(){O^}}''');
     return computeFull().then((_) {
       assertSuggestClass('A');
@@ skipping 72 matching lines @@
   test_ImportDirective_dart() {
     // SimpleStringLiteral  ImportDirective
     addTestSource('''
       import "dart^";
       main() {}''');
     return computeFull().then((_) {
       assertNotSuggested('Object');
     });
   }
 
+  test_IsExpression_local() {
+    // SimpleIdentifier  TypeName  IsExpression  IfStatement
+    addTestSource('''
+      class X {X.c(); X._d(); z() {}}
+      main() {var x; if (x is ^) { }}''');
+    return computeFull().then((_) {
+      assertNoSuggestions();
+    });
+  }
+
   test_PrefixedIdentifier() {
     // SimpleIdentifier  PrefixedIdentifier  ExpressionStatement
     addSource('/testA.dart', '''
       class A() {int x;}
       _B() {}''');
     addTestSource('''
       import "/testA.dart";
       class X {foo(){A a; a.^}}''');
     return computeFull().then((_) {
       // InvocationComputer provides suggestions for prefixed expressions
@@ skipping 72 matching lines @@
     // VariableDeclarationStatement  Block
     addSource('/testA.dart', 'var T1;');
     addTestSource('''
       import "/testA.dart";
       class C {a() {var ^}}''');
     return computeFull().then((_) {
       assertNotSuggested('T1');
     });
   }
 
-  xtest_ConstructorName_importedClass() {
-    // SimpleIdentifier  PrefixedIdentifier  TypeName  ConstructorName
-    // InstanceCreationExpression
-    addSource('/testB.dart', '''
-      lib B;
-      class X {X.c(); X._d(); z() {}}''');
-    addTestSource('''
-      import "/testB.dart";
-      var m;
-      main() {new X.^}''');
-    return computeFull().then((_) {
-      assertNoSuggestions();
-    });
-  }
-
-  xtest_ConstructorName_localClass() {
-    // SimpleIdentifier  PrefixedIdentifier  TypeName  ConstructorName
-    // InstanceCreationExpression
-    addTestSource('''
-      var m;
-      class X {X.c(); X._d(); z() {}}
-      main() {new X.^}''');
-    return computeFull().then((_) {
-      assertNoSuggestions();
-    });
-  }
-
-  // TODO (danrubel) implement
   xtest_InstanceCreationExpression() {
     // SimpleIdentifier  TypeName  ConstructorName  InstanceCreationExpression
     addSource('/testA.dart', '''
       class A {int x;}
       B() { }''');
     addTestSource('''
       import "/testA.dart";
       class C {foo(){new ^}}''');
     return computeFull().then((_) {
       assertSuggestClass('A');
       assertNotSuggested('x');
       assertNotSuggested('B');
       // Should not suggest compilation unit elements
       // which are returned by the LocalComputer
       assertNotSuggested('C');
     });
   }
 
-  // TODO (danrubel) implement
   xtest_IsExpression_imported() {
     // SimpleIdentifier  TypeName  IsExpression  IfStatement
     addSource('/testB.dart', '''
       lib B;
       class X {X.c(); X._d(); z() {}}''');
     addTestSource('''
       import "/testB.dart";
       main() {var x; if (x is ^) { }}''');
     return computeFull().then((_) {
       assertSuggestConstructor('c');
       assertNotSuggested('main');
       assertNotSuggested('X');
       assertNotSuggested('B');
       assertNotSuggested('x');
     });
   }
 
-  // TODO (danrubel) implement
-  xtest_IsExpression_local() {
-    // SimpleIdentifier  TypeName  IsExpression  IfStatement
-    addTestSource('''
-      class X {X.c(); X._d(); z() {}}
-      main() {var x; if (x is ^) { }}''');
-    return computeFull().then((_) {
-      assertNoSuggestions();
-    });
-  }
-
-  // TODO (danrubel) implement
   xtest_VariableDeclarationStatement_RHS() {
     // SimpleIdentifier  VariableDeclaration  VariableDeclarationList
     // VariableDeclarationStatement
     addSource('/testA.dart', 'class A {int x;} class _B { }');
     addTestSource('''
       import "/testA.dart";
       class C {foo(){var e = ^}}''');
     return computeFull().then((_) {
       assertSuggestClass('A');
       assertNotSuggested('x');
       assertNotSuggested('_B');
       // Should not suggest compilation unit elements
       // which are returned by the LocalComputer
       assertNotSuggested('C');
     });
   }
 }