Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 632283004: Remove implicit conversions from scoped_refptr to T* in content/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
qinmin, no sievers, Torne
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, posciak+watch_chromium.org, James Su, wjia+watch_chromium.org, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/ Manual fixups for cases the automated tooling elected to skip. BUG=110610 Committed: https://crrev.com/4b8efd09c667171b4911bdf19aab3714cd62c37a Cr-Commit-Position: refs/heads/master@{#298745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
dcheng
+torne for content/browser/android/java/ changes +sievers for content/browser/renderer_host changes +qinmin for content/renderer/media changes
6 years, 2 months ago (2014-10-07 22:17:44 UTC) #2
no sievers
lgtm
6 years, 2 months ago (2014-10-07 22:20:48 UTC) #3
Torne
lgtm
6 years, 2 months ago (2014-10-08 11:31:58 UTC) #4
qinmin
lgtm
6 years, 2 months ago (2014-10-08 17:38:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632283004/1
6 years, 2 months ago (2014-10-08 17:39:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2a17f36f7628ae2eec4964b42e7be939b799148b
6 years, 2 months ago (2014-10-08 18:10:22 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 18:12:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b8efd09c667171b4911bdf19aab3714cd62c37a
Cr-Commit-Position: refs/heads/master@{#298745}

Powered by Google App Engine
This is Rietveld 408576698