Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 632253002: DevTools: Network Panel: update "Record Network Log" button title according to state. (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: Network Panel: update "Record Network Log" button title according to state. Title should reflect action that will happen when button is pressed. BUG=414140 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M Source/devtools/front_end/network/NetworkPanel.js View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eustas
6 years, 2 months ago (2014-10-07 09:35:45 UTC) #2
vsevik
lgtm
6 years, 2 months ago (2014-10-14 06:40:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632253002/1
6 years, 2 months ago (2014-10-14 06:41:42 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 07:42:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183649

Powered by Google App Engine
This is Rietveld 408576698