base/test/trace_event_analyzer_unittest.cc - Issue 632103004: Cleanup: Better constify some strings in base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/trace_event_analyzer_unittest.cc

Issue 632103004: Cleanup: Better constify some strings in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix bad refactoring Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/trace_event_analyzer_unittest.cc

diff --git a/base/test/trace_event_analyzer_unittest.cc b/base/test/trace_event_analyzer_unittest.cc

index 56045089222500e80848267b30325b81d9b23040..0edeb141eafafa4061df6d2c74ec9c6eb71ce975 100644

--- a/base/test/trace_event_analyzer_unittest.cc

+++ b/base/test/trace_event_analyzer_unittest.cc

@@ -86,7 +86,7 @@ TEST_F(TraceEventAnalyzerTest, TraceEvent) {

int int_num = 2;

double double_num = 3.5;

- const char* str = "the string";

+ const char str[] = "the string";

TraceEvent event;

event.arg_numbers["false"] = 0.0;

@@ -508,7 +508,7 @@ TEST_F(TraceEventAnalyzerTest, BeginEndAssocations) {

TEST_F(TraceEventAnalyzerTest, MergeAssociatedEventArgs) {

ManualSetUp();

- const char* arg_string = "arg_string";

+ const char arg_string[] = "arg_string";

BeginTracing();

{

TRACE_EVENT_BEGIN0("cat1", "name1");