Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: base/threading/thread_id_name_manager_unittest.cc

Issue 632103004: Cleanup: Better constify some strings in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bad refactoring Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/test/trace_event_analyzer_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/threading/thread_id_name_manager.h" 5 #include "base/threading/thread_id_name_manager.h"
6 6
7 #include "base/threading/platform_thread.h" 7 #include "base/threading/platform_thread.h"
8 #include "base/threading/thread.h" 8 #include "base/threading/thread.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "testing/platform_test.h" 10 #include "testing/platform_test.h"
11 11
12 typedef PlatformTest ThreadIdNameManagerTest; 12 typedef PlatformTest ThreadIdNameManagerTest;
13 13
14 namespace { 14 namespace {
15 15
16 static const char* kAThread = "a thread"; 16 const char kAThread[] = "a thread";
17 static const char* kBThread = "b thread"; 17 const char kBThread[] = "b thread";
18 18
19 TEST_F(ThreadIdNameManagerTest, AddThreads) { 19 TEST_F(ThreadIdNameManagerTest, AddThreads) {
20 base::ThreadIdNameManager* manager = base::ThreadIdNameManager::GetInstance(); 20 base::ThreadIdNameManager* manager = base::ThreadIdNameManager::GetInstance();
21 base::Thread thread_a(kAThread); 21 base::Thread thread_a(kAThread);
22 base::Thread thread_b(kBThread); 22 base::Thread thread_b(kBThread);
23 23
24 thread_a.Start(); 24 thread_a.Start();
25 thread_b.Start(); 25 thread_b.Start();
26 26
27 EXPECT_STREQ(kAThread, manager->GetName(thread_a.thread_id())); 27 EXPECT_STREQ(kAThread, manager->GetName(thread_a.thread_id()));
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 base::PlatformThread::SetName("New name"); 84 base::PlatformThread::SetName("New name");
85 EXPECT_NE(version, manager->GetName(a_id)); 85 EXPECT_NE(version, manager->GetName(a_id));
86 86
87 base::PlatformThread::SetName("Test Name"); 87 base::PlatformThread::SetName("Test Name");
88 EXPECT_EQ(version, manager->GetName(a_id)); 88 EXPECT_EQ(version, manager->GetName(a_id));
89 89
90 base::PlatformThread::SetName(""); 90 base::PlatformThread::SetName("");
91 } 91 }
92 92
93 } // namespace 93 } // namespace
OLDNEW
« no previous file with comments | « base/test/trace_event_analyzer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698