Cleanup: Better constify some strings in base.

base/test/expectations/parser_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/expectations/parser.h"
 
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 143 matching lines @@
 }
 
 TEST_F(TestExpectationParserTest, WeirdSpaces) {
   Parser(this, "   BUG       [Linux]        Weird  = Skip    ").Parse();
   EXPECT_EQ(1u, expectations_.size());
   EXPECT_TRUE(syntax_error_.empty());
   EXPECT_EQ(0u, data_errors_.size());
 }
 
 TEST_F(TestExpectationParserTest, SyntaxErrors) {
-  const char* kErrors[] = {
+  const char* const kErrors[] = {
     "Foo [ dfasd",
     "Foo [Linux] # This is an illegal comment",
     "Foo [Linux] Bar # Another illegal comment.",
     "Foo [Linux] Bar = # Another illegal comment.",
     "Foo[Linux]Bar=Failure",
     "Foo\n[Linux] Bar = Failure",
     "Foo [\nLinux] Bar = Failure",
     "Foo [Linux\n] Bar = Failure",
     "Foo [ Linux ] \n Bar = Failure",
     "Foo [ Linux ] Bar =\nFailure",
     "Foo [ Linux \n ] Bar =\nFailure",
   };
 
   for (size_t i = 0; i < arraysize(kErrors); ++i) {
     Parser(this, kErrors[i]).Parse();
     EXPECT_FALSE(syntax_error_.empty())
         << "Should have error for #" << i << ": " << kErrors[i];
     syntax_error_.clear();
   }
 }
 
 TEST_F(TestExpectationParserTest, DataErrors) {
-  const char* kOneError[] = {
+  const char* const kOneError[] = {
     "http://crbug.com/1234 [MagicBrowzR] BadModifier = Timeout",
     "________ [Linux] BadResult = WhatNow",
     "http://wkb.ug/1234 [Debug Release Win-7] MultipleConfigs = Skip",
   };
 
   for (size_t i = 0; i < arraysize(kOneError); ++i) {
     Parser(this, kOneError[i]).Parse();
     EXPECT_EQ(1u, data_errors_.size()) << kOneError[i];
     data_errors_.clear();
   }
 
-  const char* kTwoErrors[] = {
+  const char* const kTwoErrors[] = {
     ". [Mac-TurningIntoiOS] BadModifierVariant.BadResult = Foobar",
     "1234 [ Debug Release OS/2 ] MultipleConfigs.BadModifier = Pass",
   };
 
   for (size_t i = 0; i < arraysize(kTwoErrors); ++i) {
     Parser(this, kTwoErrors[i]).Parse();
     EXPECT_EQ(2u, data_errors_.size()) << kTwoErrors[i];
     data_errors_.clear();
   }
 }