Cleanup: Better constify some strings in base.

base/test/expectations/expectation_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/expectations/expectation.h"
 
 #include "base/basictypes.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 TEST(TestExpectationsFunctionsTest, ResultFromString) {
@@ skipping 53 matching lines @@
   EXPECT_EQ("", platform.variant);
 
   EXPECT_TRUE(PlatformFromString("Linux-", &platform));
   EXPECT_EQ("Linux", platform.name);
   EXPECT_EQ("", platform.variant);
 
   EXPECT_FALSE(PlatformFromString("", &platform));
 }
 
 TEST(TestExpectationsFunctionsTest, IsValidPlatform) {
-  const char* kValidPlatforms[] = {
+  const char* const kValidPlatforms[] = {
     "Win",
     "Win-XP",
     "Win-Vista",
     "Win-7",
     "Win-8",
     "Mac",
     "Mac-10.6",
     "Mac-10.7",
     "Mac-10.8",
     "Linux",
     "Linux-32",
     "Linux-64",
     "ChromeOS",
     "iOS",
     "Android",
   };
 
-  const char* kInvalidPlatforms[] = {
+  const char* const kInvalidPlatforms[] = {
     "Solaris",
     "Plan9",
   };
 
   for (size_t i = 0; i < arraysize(kValidPlatforms); ++i) {
     test_expectations::Platform platform;
     EXPECT_TRUE(test_expectations::PlatformFromString(
         kValidPlatforms[i], &platform)) << kValidPlatforms[i];
   }
 
   for (size_t i = 0; i < arraysize(kInvalidPlatforms); ++i) {
     test_expectations::Platform platform;
     EXPECT_FALSE(test_expectations::PlatformFromString(
         kInvalidPlatforms[i], &platform)) << kInvalidPlatforms[i];
   }
 }
 
 TEST(TestExpectationsFunctionsTest, CurrentPlatform) {
   test_expectations::Platform current =
       test_expectations::GetCurrentPlatform();
   EXPECT_FALSE(current.name.empty());
 }
 
 TEST(TestExpectationsFunctionsTest, CurrentConfiguration) {
   test_expectations::Configuration current =
       test_expectations::GetCurrentConfiguration();
   EXPECT_NE(test_expectations::CONFIGURATION_UNSPECIFIED, current);
 }