Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: base/sys_info_chromeos.cc

Issue 632103004: Cleanup: Better constify some strings in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bad refactoring Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/strings/stringprintf_unittest.cc ('k') | base/sys_info_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/sys_info.h" 5 #include "base/sys_info.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/environment.h" 8 #include "base/environment.h"
9 #include "base/files/file.h" 9 #include "base/files/file.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "base/files/file_util.h" 11 #include "base/files/file_util.h"
12 #include "base/lazy_instance.h" 12 #include "base/lazy_instance.h"
13 #include "base/strings/string_number_conversions.h" 13 #include "base/strings/string_number_conversions.h"
14 #include "base/strings/string_piece.h" 14 #include "base/strings/string_piece.h"
15 #include "base/strings/string_split.h" 15 #include "base/strings/string_split.h"
16 #include "base/strings/string_tokenizer.h" 16 #include "base/strings/string_tokenizer.h"
17 #include "base/strings/string_util.h" 17 #include "base/strings/string_util.h"
18 #include "base/threading/thread_restrictions.h" 18 #include "base/threading/thread_restrictions.h"
19 19
20 namespace base { 20 namespace base {
21 21
22 namespace { 22 namespace {
23 23
24 const char* kLinuxStandardBaseVersionKeys[] = { 24 const char* const kLinuxStandardBaseVersionKeys[] = {
25 "CHROMEOS_RELEASE_VERSION", 25 "CHROMEOS_RELEASE_VERSION",
26 "GOOGLE_RELEASE", 26 "GOOGLE_RELEASE",
27 "DISTRIB_RELEASE", 27 "DISTRIB_RELEASE",
28 }; 28 };
29 29
30 const char kChromeOsReleaseNameKey[] = "CHROMEOS_RELEASE_NAME"; 30 const char kChromeOsReleaseNameKey[] = "CHROMEOS_RELEASE_NAME";
31 31
32 const char* const kChromeOsReleaseNames[] = { 32 const char* const kChromeOsReleaseNames[] = {
33 "Chrome OS", 33 "Chrome OS",
34 "Chromium OS", 34 "Chromium OS",
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 void SysInfo::SetChromeOSVersionInfoForTest(const std::string& lsb_release, 210 void SysInfo::SetChromeOSVersionInfoForTest(const std::string& lsb_release,
211 const Time& lsb_release_time) { 211 const Time& lsb_release_time) {
212 scoped_ptr<Environment> env(Environment::Create()); 212 scoped_ptr<Environment> env(Environment::Create());
213 env->SetVar(kLsbReleaseKey, lsb_release); 213 env->SetVar(kLsbReleaseKey, lsb_release);
214 env->SetVar(kLsbReleaseTimeKey, 214 env->SetVar(kLsbReleaseTimeKey,
215 DoubleToString(lsb_release_time.ToDoubleT())); 215 DoubleToString(lsb_release_time.ToDoubleT()));
216 g_chrome_os_version_info.Get().Parse(); 216 g_chrome_os_version_info.Get().Parse();
217 } 217 }
218 218
219 } // namespace base 219 } // namespace base
OLDNEW
« no previous file with comments | « base/strings/stringprintf_unittest.cc ('k') | base/sys_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698