Cleanup: Better constify some strings in base.

base/strings/stringprintf_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/stringprintf.h"
 
 #include <errno.h>
 
 #include "base/basictypes.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 88 matching lines @@
   }
 }
 
 // Test very large sprintfs that will cause the buffer to grow.
 TEST(StringPrintfTest, Grow) {
   char src[1026];
   for (size_t i = 0; i < arraysize(src); i++)
     src[i] = 'A';
   src[1025] = 0;
 
-  const char* fmt = "%sB%sB%sB%sB%sB%sB%s";
+  const char fmt[] = "%sB%sB%sB%sB%sB%sB%s";
 
   std::string out;
   SStringPrintf(&out, fmt, src, src, src, src, src, src, src);
 
   const int kRefSize = 320000;
   char* ref = new char[kRefSize];
 #if defined(OS_WIN)
   sprintf_s(ref, kRefSize, fmt, src, src, src, src, src, src, src);
 #elif defined(OS_POSIX)
   snprintf(ref, kRefSize, fmt, src, src, src, src, src, src, src);
 #endif
 
   EXPECT_STREQ(ref, out.c_str());
   delete[] ref;
 }
 
 TEST(StringPrintfTest, StringAppendV) {
   std::string out;
   StringAppendVTestHelper(&out, "%d foo %s", 1, "bar");
   EXPECT_EQ("1 foo bar", out);
 }
 
 // Test the boundary condition for the size of the string_util's
 // internal buffer.
 TEST(StringPrintfTest, GrowBoundary) {
-  const int string_util_buf_len = 1024;
+  const int kStringUtilBufLen = 1024;
   // Our buffer should be one larger than the size of StringAppendVT's stack
   // buffer.
-  const int buf_len = string_util_buf_len + 1;
-  char src[buf_len + 1];  // Need extra one for NULL-terminator.
-  for (int i = 0; i < buf_len; ++i)
+  // And need extra one for NULL-terminator.
+  const int kBufLen = kStringUtilBufLen + 1 + 1;
+  char src[kBufLen];
+  for (int i = 0; i < kBufLen - 1; ++i)
     src[i] = 'a';
-  src[buf_len] = 0;
+  src[kBufLen - 1] = 0;
 
   std::string out;
   SStringPrintf(&out, "%s", src);
 
   EXPECT_STREQ(src, out.c_str());
 }
 
 // TODO(evanm): what's the proper cross-platform test here?
 #if defined(OS_WIN)
 // sprintf in Visual Studio fails when given U+FFFF. This tests that the
@@ skipping 26 matching lines @@
 TEST(StringPrintfTest, StringPrintfErrno) {
   errno = 1;
   EXPECT_EQ("", StringPrintf("%s", ""));
   EXPECT_EQ(1, errno);
   std::string out;
   StringAppendVTestHelper(&out, "%d foo %s", 1, "bar");
   EXPECT_EQ(1, errno);
 }
 
 }  // namespace base