Cleanup: Better constify some strings in base.

base/md5_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/md5.h"
@@ skipping 15 matching lines @@
     digest.a[i] = data[i] & 0xff;
 
   std::string actual = MD5DigestToBase16(digest);
   std::string expected = "d41d8cd98f00b204e9800998ecf8427e";
 
   EXPECT_EQ(expected, actual);
 }
 
 TEST(MD5, MD5SumEmtpyData) {
   MD5Digest digest;
-  const char* data = "";
+  const char data[] = "";
 
   MD5Sum(data, strlen(data), &digest);
 
   int expected[] = {
     0xd4, 0x1d, 0x8c, 0xd9,
     0x8f, 0x00, 0xb2, 0x04,
     0xe9, 0x80, 0x09, 0x98,
     0xec, 0xf8, 0x42, 0x7e
   };
 
   for (int i = 0; i < 16; ++i)
     EXPECT_EQ(expected[i], digest.a[i] & 0xFF);
 }
 
 TEST(MD5, MD5SumOneByteData) {
   MD5Digest digest;
-  const char* data = "a";
+  const char data[] = "a";
 
   MD5Sum(data, strlen(data), &digest);
 
   int expected[] = {
     0x0c, 0xc1, 0x75, 0xb9,
     0xc0, 0xf1, 0xb6, 0xa8,
     0x31, 0xc3, 0x99, 0xe2,
     0x69, 0x77, 0x26, 0x61
   };
 
@@ skipping 179 matching lines @@
 
   // The header and full digest pairs are the same, and they aren't the same as
   // each other.
   EXPECT_TRUE(!memcmp(&header_digest, &check_header_digest,
                       sizeof(header_digest)));
   EXPECT_TRUE(!memcmp(&digest, &check_full_digest, sizeof(digest)));
   EXPECT_FALSE(!memcmp(&digest, &header_digest, sizeof(digest)));
 }
 
 }  // namespace base