Cleanup: Better constify some strings in base.

base/json/json_reader_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_reader.h"
 
 #include "base/base_paths.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 487 matching lines @@
   EXPECT_EQ("\xe2\x82\xac""3,14", str_val);
 
   root.reset(JSONReader().ReadToValue("\"\\ud83d\\udca9\\ud83d\\udc6c\""));
   ASSERT_TRUE(root.get());
   EXPECT_TRUE(root->IsType(Value::TYPE_STRING));
   str_val.clear();
   EXPECT_TRUE(root->GetAsString(&str_val));
   EXPECT_EQ("\xf0\x9f\x92\xa9\xf0\x9f\x91\xac", str_val);
 
   // Test invalid utf16 strings.
-  const char* cases[] = {
+  const char* const cases[] = {
     "\"\\u123\"",  // Invalid scalar.
     "\"\\ud83d\"",  // Invalid scalar.
     "\"\\u$%@!\"",  // Invalid scalar.
     "\"\\uzz89\"",  // Invalid scalar.
     "\"\\ud83d\\udca\"",  // Invalid lower surrogate.
     "\"\\ud83d\\ud83d\"",  // Invalid lower surrogate.
     "\"\\ud83foo\"",  // No lower surrogate.
     "\"\\ud83\\foo\""  // No lower surrogate.
   };
   for (size_t i = 0; i < arraysize(cases); ++i) {
@@ skipping 101 matching lines @@
   EXPECT_TRUE(list_value_0->GetAsString(&s));
   EXPECT_EQ("a", s);
   EXPECT_TRUE(list_value_1->GetAsString(&s));
   EXPECT_EQ("b", s);
 }
 
 // A smattering of invalid JSON designed to test specific portions of the
 // parser implementation against buffer overflow. Best run with DCHECKs so
 // that the one in NextChar fires.
 TEST(JSONReaderTest, InvalidSanity) {
-  const char* invalid_json[] = {
+  const char* const invalid_json[] = {
       "/* test *",
       "{\"foo\"",
       "{\"foo\":",
       "  [",
       "\"\\u123g\"",
       "{\n\"eh:\n}",
   };
 
   for (size_t i = 0; i < arraysize(invalid_json); ++i) {
     JSONReader reader;
     LOG(INFO) << "Sanity test " << i << ": <" << invalid_json[i] << ">";
     EXPECT_FALSE(reader.ReadToValue(invalid_json[i]));
     EXPECT_NE(JSONReader::JSON_NO_ERROR, reader.error_code());
     EXPECT_NE("", reader.GetErrorMessage());
   }
 }
 
 TEST(JSONReaderTest, IllegalTrailingNull) {
   const char json[] = { '"', 'n', 'u', 'l', 'l', '"', '\0' };
   std::string json_string(json, sizeof(json));
   JSONReader reader;
   EXPECT_FALSE(reader.ReadToValue(json_string));
   EXPECT_EQ(JSONReader::JSON_UNEXPECTED_DATA_AFTER_ROOT, reader.error_code());
 }
 
 }  // namespace base