Cleanup: Better constify some strings in base.

base/debug/crash_logging_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/crash_logging.h"
 
 #include <map>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 26 matching lines @@
                           const base::StringPiece& value) {
     (*key_values_)[key.as_string()] = value.as_string();
   }
 
   static void ClearKeyValue(const base::StringPiece& key) {
     key_values_->erase(key.as_string());
   }
 };
 
 TEST_F(CrashLoggingTest, SetClearSingle) {
-  const char* kTestKey = "test-key";
+  const char kTestKey[] = "test-key";
   base::debug::CrashKey keys[] = { { kTestKey, 255 } };
   base::debug::InitCrashKeys(keys, arraysize(keys), 255);
 
   base::debug::SetCrashKeyValue(kTestKey, "value");
   EXPECT_EQ("value", (*key_values_)[kTestKey]);
 
   base::debug::ClearCrashKey(kTestKey);
   EXPECT_TRUE(key_values_->end() == key_values_->find(kTestKey));
 }
 
 TEST_F(CrashLoggingTest, SetChunked) {
-  const char* kTestKey = "chunky";
-  const char* kChunk1 = "chunky-1";
-  const char* kChunk2 = "chunky-2";
-  const char* kChunk3 = "chunky-3";
+  const char kTestKey[] = "chunky";
+  const char kChunk1[] = "chunky-1";
+  const char kChunk2[] = "chunky-2";
+  const char kChunk3[] = "chunky-3";
   base::debug::CrashKey keys[] = { { kTestKey, 15 } };
   base::debug::InitCrashKeys(keys, arraysize(keys), 5);
 
   std::map<std::string, std::string>& values = *key_values_;
 
   // Fill only the first chunk.
   base::debug::SetCrashKeyValue(kTestKey, "foo");
   EXPECT_EQ(1u, values.size());
   EXPECT_EQ("foo", values[kChunk1]);
   EXPECT_TRUE(values.end() == values.find(kChunk2));
@@ skipping 24 matching lines @@
 
   // Clear everything.
   base::debug::ClearCrashKey(kTestKey);
   EXPECT_EQ(0u, values.size());
   EXPECT_TRUE(values.end() == values.find(kChunk1));
   EXPECT_TRUE(values.end() == values.find(kChunk2));
   EXPECT_TRUE(values.end() == values.find(kChunk3));
 }
 
 TEST_F(CrashLoggingTest, ScopedCrashKey) {
-  const char* kTestKey = "test-key";
+  const char kTestKey[] = "test-key";
   base::debug::CrashKey keys[] = { { kTestKey, 255 } };
   base::debug::InitCrashKeys(keys, arraysize(keys), 255);
 
   EXPECT_EQ(0u, key_values_->size());
   EXPECT_TRUE(key_values_->end() == key_values_->find(kTestKey));
   {
     base::debug::ScopedCrashKey scoped_crash_key(kTestKey, "value");
     EXPECT_EQ("value", (*key_values_)[kTestKey]);
     EXPECT_EQ(1u, key_values_->size());
   }
@@ skipping 55 matching lines @@
   EXPECT_EQ("wor", results[2]);
   EXPECT_EQ("ld",  results[3]);
 }
 
 TEST_F(CrashLoggingTest, ChunkRounding) {
   // If max_length=12 and max_chunk_length=5, there should be 3 chunks,
   // not 2.
   base::debug::CrashKey key = { "round", 12 };
   EXPECT_EQ(3u, base::debug::InitCrashKeys(&key, 1, 5));
 }