Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 632043002: Revert of Remove stale RFHM check now that unload runs in the background. (Closed)

Created:
6 years, 2 months ago by Charlie Reis
Modified:
4 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove stale RFHM check now that unload runs in the background. (patchset #1 id:1 of https://codereview.chromium.org/617273004/) Reason for revert: The new CHECK fails if render_view_host_->is_waiting_for_close_ack_ is true. See http://crbug.com/420557. Original issue's description: > Remove stale RFHM check now that unload runs in the background. > > BUG=402020 > TEST=No behavior change. > > Committed: https://crrev.com/52538dfb0dee9307b87bb688569ec23893a14cab > Cr-Commit-Position: refs/heads/master@{#297688} TBR=nasko@chromium.org NOTREECHECKS=true NOTRY=true BUG=402020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Charlie Reis
Created Revert of Remove stale RFHM check now that unload runs in the background.
6 years, 2 months ago (2014-10-06 22:39:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632043002/1
6 years, 2 months ago (2014-10-06 22:45:17 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 22:51:55 UTC) #4
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698