Chromium Code Reviews Chromium Code Reviews
Issue 632033002:
Add PLT measurement to Resource Prefetching for Mobile Web (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 592e892e83340c18b428e910c66b170b03f750a0..a1710831c174fdc065555b493f9bace36ff73f28 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -27935,6 +27935,22 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="ResourcePrefetchPredictor.NetworkType" |
| + enum="ResourcePrefetchPredictorNetworkType"> |
| + <owner>zhenw@chromium.org</owner> |
| + <summary>Records the number of pages on each type of network.</summary> |
|
Alexei Svitkine (slow)
2014/10/29 19:09:46
Please mention *when* this is recorded. After a pa
Zhen Wang
2014/10/29 19:56:07
Done.
|
| +</histogram> |
| + |
| +<histogram name="ResourcePrefetchPredictor.PLT" units="milliseconds"> |
| + <owner>zhenw@chromium.org</owner> |
| + <summary> |
| + Page load time. It starts from when the main frame URL request is sent out |
| + to when the main frame document load is completed. |
| + |
| + This is recorded for both prefetched and non-prefetched pages. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="SafeBrowsing.EnabledSettingChanged" enum="BooleanEnabled"> |
| <owner>feng@chromium.org</owner> |
| <summary> |
| @@ -51166,6 +51182,19 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="1" label="Has client"/> |
| </enum> |
| +<enum name="ResourcePrefetchPredictorNetworkType" type="int"> |
| + <int value="0" label="CONNECTION_UNKNOWN"/> |
| + <int value="1" label="CONNECTION_ETHERNET"/> |
| + <int value="2" label="CONNECTION_WIFI"/> |
| + <int value="3" label="CONNECTION_2G"/> |
| + <int value="4" label="CONNECTION_3G"/> |
| + <int value="5" label="CONNECTION_4G"/> |
| + <int value="6" label="CONNECTION_NONE"/> |
| + <int value="7" label="CONNECTION_BLUETOOTH"/> |
| + <int value="8" label="CONNECTION_CELLULAR"/> |
|
Alexei Svitkine (slow)
2014/10/29 19:09:46
This and the value below are now negative, right?
Zhen Wang
2014/10/29 19:56:07
Ah, right. Thanks for catching this!
|
| + <int value="9" label="CONNECTION_ALL"/> |
| +</enum> |
| + |
| <enum name="ResourceType" type="int"> |
| <int value="0" label="Main resource"/> |
| <int value="1" label="Image"/> |
| @@ -57396,6 +57425,48 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <affected-histogram name="Event.Latency.Renderer2"/> |
| </histogram_suffixes> |
| +<histogram_suffixes name="ResourcePrefetchPredictorNetworkTypePrefetch" |
| + separator="."> |
| + <suffix name="NotPrefetched" |
| + label="Number of non-prefetched pages on each type of network."/> |
| + <suffix name="Prefetched" |
| + label="Number of prefetched pages on each type of network."/> |
| + <affected-histogram name="ResourcePrefetchPredictor.NetworkType"/> |
| +</histogram_suffixes> |
| + |
| +<histogram_suffixes name="ResourcePrefetchPredictorPLTNetworkTypes"> |
| + <suffix name="2G" label="Page load time in 2G network."/> |
| + <suffix name="3G" label="Page load time in 3G network."/> |
| + <suffix name="4G" label="Page load time in 4G network."/> |
| + <suffix name="Bluetooth" label="Page load time in bluetooth network."/> |
| + <suffix name="Cellular" label="Page load time in cellular network."/> |
| + <suffix name="Ethernet" label="Page load time in Ethernet."/> |
| + <suffix name="None" label="Page load time without network connection."/> |
| + <suffix name="Unknown" label="Page load time in unknown type of network."/> |
| + <suffix name="WiFi" label="Page load time in WiFi network."/> |
| + <affected-histogram name="ResourcePrefetchPredictor.PLT"/> |
| + <affected-histogram name="ResourcePrefetchPredictor.PLT.NotPrefetched"/> |
| + <affected-histogram name="ResourcePrefetchPredictor.PLT.Prefetched"/> |
| + <affected-histogram name="ResourcePrefetchPredictor.PLT.Prefetched.Host"/> |
| + <affected-histogram name="ResourcePrefetchPredictor.PLT.Prefetched.Url"/> |
| +</histogram_suffixes> |
| + |
| +<histogram_suffixes name="ResourcePrefetchPredictorPLTPrefetch" separator="."> |
| + <suffix name="NotPrefetched" |
| + label="Page load time for non-prefetched pages."/> |
| + <suffix name="Prefetched" label="Page load time for prefetched pages."/> |
| + <affected-histogram name="ResourcePrefetchPredictor.PLT"/> |
| +</histogram_suffixes> |
| + |
| +<histogram_suffixes name="ResourcePrefetchPredictorPLTPrefetchType" |
| + separator="."> |
| + <suffix name="Host" |
| + label="Page load time for prefetched pages based on main frame host."/> |
| + <suffix name="Url" |
| + label="Page load time for prefetched pages based on main frame URL."/> |
| + <affected-histogram name="ResourcePrefetchPredictor.PLT.Prefetched"/> |
| +</histogram_suffixes> |
| + |
| <histogram_suffixes name="SBInterstitial"> |
| <obsolete> |
| deprecated November 10 2012 crrev.com/167056 |
