Index: tools/telemetry/telemetry/unittest/page_set_smoke_test.py |
diff --git a/tools/telemetry/telemetry/unittest/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest/page_set_smoke_test.py |
index 274161b9065833acb5db2fc538d16c1cd8c0fe22..717e8a09be3188fcfeec23a81ff438a79da27e51 100644 |
--- a/tools/telemetry/telemetry/unittest/page_set_smoke_test.py |
+++ b/tools/telemetry/telemetry/unittest/page_set_smoke_test.py |
@@ -61,6 +61,30 @@ class PageSetSmokeTest(unittest.TestCase): |
for page in page_set.pages: |
self.CheckAttributesOfPageBasicAttributes(page) |
+ def CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions( |
+ self, page_set): |
+ # This test is to make sure that page has been converted to use single |
+ # RunPageInteractions does not contain legacy run method. |
+ # For more context see: crbug.com/418375 |
+ # TODO(nednguyen, ernstm): remove this test when crbug.com/418375 is marked |
+ # fixed. |
+ LEGACY_RUN_METHODS = [ |
+ 'RunMediaMetrics', |
+ 'RunNoOp', |
+ 'RunRepaint', |
+ 'RunPrepareForScreenShot', |
+ 'RunSmoothness', |
+ 'RunWebrtc' |
+ ] |
+ for page in page_set.pages: |
+ if hasattr(page, 'RunPageInteractions'): |
+ for legacy_run_method in LEGACY_RUN_METHODS: |
+ self.assertTrue( |
+ not hasattr(page, legacy_run_method), |
+ msg=('page %s in page_set %s has both legacy Run.. methods and ' |
+ 'RunPageInteractions defined. ' % ( |
+ page, page_set.file_path))) |
+ |
def CheckAttributesOfPageSetBasicAttributes(self, page_set): |
if page_set.file_path is not None: |
self.assertTrue( |
@@ -115,3 +139,4 @@ class PageSetSmokeTest(unittest.TestCase): |
self.CheckArchive(page_set) |
self.CheckCredentials(page_set) |
self.CheckAttributes(page_set) |
+ self.CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(page_set) |