Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(44)

Issue 6320021: Merge 76680 - 2011-01-26 Pavel Feldman <pfeldman@chromium.org>... (Closed)

Created:
9 years, 8 months ago by mnaganov (inactive)
Modified:
9 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Merge 76680 - 2011-01-26 Pavel Feldman <pfeldman@chromium.org>; Reviewed by Yury Semikhatsky. Web Inspector: Incorrect on-hover evaluation of a variable named 'profile'. https://bugs.webkit.org/show_bug.cgi?id=53018 * inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getCompletions): (WebCore::InjectedScript::getCompletionsOnCallFrame): * inspector/InjectedScript.h: * inspector/InjectedScriptSource.js: (.): * inspector/Inspector.idl: * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame): * inspector/InspectorDebuggerAgent.h: * inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::getCompletions): * inspector/InspectorRuntimeAgent.h: * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup): * inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): TBR=pfeldman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -68 lines) Patch
M Source/WebCore/inspector/InjectedScript.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InjectedScript.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptSource.js View 7 chunks +15 lines, -14 lines 0 comments Download
M Source/WebCore/inspector/Inspector.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorDebuggerAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorDebuggerAgent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorRuntimeAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorRuntimeAgent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/front-end/ConsoleView.js View 4 chunks +7 lines, -11 lines 0 comments Download
M Source/WebCore/inspector/front-end/ScriptsPanel.js View 2 chunks +6 lines, -15 lines 0 comments Download
M Source/WebCore/inspector/front-end/SourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
mnaganov (inactive)
9 years, 8 months ago (2011-01-28 14:06:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698