Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 631873004: Removing repeated retrieval of width and height for PastePopup menu. (Closed)

Created:
6 years, 2 months ago by AKVT
Modified:
6 years, 2 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing repeated retrieval of width and height for PastePopup menu. Optimized the code by removing extra assignment of width and height inside PastePopupMenu. BUG= Committed: https://crrev.com/328900d764e4be50e929c35164aae6a578cd5055 Cr-Commit-Position: refs/heads/master@{#298537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
AKVT
@jdduke PTAL
6 years, 2 months ago (2014-10-07 17:45:03 UTC) #2
jdduke (slow)
Weird, yeah, I wonder why we didn't do this before? In any case, lgtm, thanks!
6 years, 2 months ago (2014-10-07 17:46:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631873004/1
6 years, 2 months ago (2014-10-07 18:11:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 37d50838355ac607290c6854b8bb346348862762
6 years, 2 months ago (2014-10-07 19:07:29 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 19:08:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/328900d764e4be50e929c35164aae6a578cd5055
Cr-Commit-Position: refs/heads/master@{#298537}

Powered by Google App Engine
This is Rietveld 408576698