Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 631833002: Move color chooser objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Keep ~ColorInputType empty Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | Source/web/ColorChooserPopupUIController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index ee5bdbe1b2693ecb9f3d38f744f804418b04287b..399dd660372e119fe49755e988a70de34208f5a2 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -579,13 +579,13 @@ void ChromeClientImpl::print(LocalFrame* frame)
m_webView->client()->printPage(WebLocalFrameImpl::fromFrame(frame));
}
-PassOwnPtr<ColorChooser> ChromeClientImpl::createColorChooser(LocalFrame* frame, ColorChooserClient* chooserClient, const Color&)
+PassOwnPtrWillBeRawPtr<ColorChooser> ChromeClientImpl::createColorChooser(LocalFrame* frame, ColorChooserClient* chooserClient, const Color&)
{
- OwnPtr<ColorChooserUIController> controller;
+ OwnPtrWillBeRawPtr<ColorChooserUIController> controller = nullptr;
if (RuntimeEnabledFeatures::pagePopupEnabled())
- controller = adoptPtr(new ColorChooserPopupUIController(frame, this, chooserClient));
+ controller = ColorChooserPopupUIController::create(frame, this, chooserClient);
else
- controller = adoptPtr(new ColorChooserUIController(frame, chooserClient));
+ controller = ColorChooserUIController::create(frame, chooserClient);
controller->openUI();
return controller.release();
}
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | Source/web/ColorChooserPopupUIController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698