Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: Source/core/html/forms/ColorInputType.h

Issue 631833002: Move color chooser objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Keep ~ColorInputType empty Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/forms/ColorChooserClient.h ('k') | Source/core/html/forms/ColorInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/ColorInputType.h
diff --git a/Source/core/html/forms/ColorInputType.h b/Source/core/html/forms/ColorInputType.h
index 159f5b33633c23058983cdfd1c3b478f473caef0..49e33f58da7a69fb93c4c3b7abd58c694a9fa998 100644
--- a/Source/core/html/forms/ColorInputType.h
+++ b/Source/core/html/forms/ColorInputType.h
@@ -39,9 +39,11 @@ namespace blink {
class ColorChooser;
class ColorInputType final : public BaseClickableWithKeyInputType, public ColorChooserClient {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ColorInputType);
public:
static PassRefPtrWillBeRawPtr<InputType> create(HTMLInputElement&);
virtual ~ColorInputType();
+ virtual void trace(Visitor*) override;
// ColorChooserClient implementation.
virtual void didChooseColor(const Color&) override;
@@ -73,7 +75,7 @@ private:
void endColorChooser();
HTMLElement* shadowColorSwatch() const;
- OwnPtr<ColorChooser> m_chooser;
+ OwnPtrWillBeMember<ColorChooser> m_chooser;
};
} // namespace blink
« no previous file with comments | « Source/core/html/forms/ColorChooserClient.h ('k') | Source/core/html/forms/ColorInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698