Source/core/loader/EmptyClients.h - Issue 631833002: Move color chooser objects to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/EmptyClients.h

Issue 631833002: Move color chooser objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make ColorChooserUIController::m_client protected, not private Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/EmptyClients.h

diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h

index 6b72c5d9448178610be40fd4ef69cc3493378793..d018da0761c87b873ade055865e211d40d1824da 100644

--- a/Source/core/loader/EmptyClients.h

+++ b/Source/core/loader/EmptyClients.h

@@ -144,7 +144,7 @@ public:

virtual void enumerateChosenDirectory(FileChooser*) OVERRIDE { }

- virtual PassOwnPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color&) OVERRIDE;

+ virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color&) OVERRIDE;

virtual PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) OVERRIDE;

virtual void openTextDataListChooser(HTMLInputElement&) OVERRIDE;