Source/core/html/forms/ColorChooser.h - Issue 631833002: Move color chooser objects to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/ColorChooser.h

Issue 631833002: Move color chooser objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make ColorChooserUIController::m_client protected, not private Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/ColorChooser.h

diff --git a/Source/core/html/forms/ColorChooser.h b/Source/core/html/forms/ColorChooser.h

index ad39c1c0ff5b8dacaa463363dd3a0d3125676abe..f5e2abef1019e59e9f515989cd25ae0a25edccfe 100644

--- a/Source/core/html/forms/ColorChooser.h

+++ b/Source/core/html/forms/ColorChooser.h

@@ -30,15 +30,18 @@

#ifndef ColorChooser_h

#define ColorChooser_h

+#include "platform/heap/Handle.h"

namespace blink {

class AXObject;

class Color;

-class ColorChooser {

+class ColorChooser : public WillBeGarbageCollectedMixin {

public:

ColorChooser();

virtual ~ColorChooser();

+ virtual void trace(Visitor*) { }

virtual void setSelectedColor(const Color&) { }

virtual void endChooser() { }