Source/core/page/Chrome.h - Issue 631833002: Move color chooser objects to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Chrome.h

Issue 631833002: Move color chooser objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Safer finalization Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/Chrome.h

diff --git a/Source/core/page/Chrome.h b/Source/core/page/Chrome.h

index 3563c547f2763023a2cc4d7cf378789606e98f81..f64cb9398adc0f038b343a15753f7d81cbbaf072 100644

--- a/Source/core/page/Chrome.h

+++ b/Source/core/page/Chrome.h

@@ -115,7 +115,7 @@ public:

void print(LocalFrame*);

- PassOwnPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color& initialColor);

+ PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooser(LocalFrame*, ColorChooserClient*, const Color& initialColor);

PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&);

void openTextDataListChooser(HTMLInputElement&);

@@ -141,6 +141,6 @@ private:

Vector<PopupOpeningObserver*> m_popupOpeningObservers;

};

+} // namespace blink

#endif // Chrome_h