Move color chooser objects to the Oilpan heap.

Source/core/html/forms/ColorInputType.cpp

Index: Source/core/html/forms/ColorInputType.cpp
diff --git a/Source/core/html/forms/ColorInputType.cpp b/Source/core/html/forms/ColorInputType.cpp
index 3edd2dead5a76c7375d62458d16633f54add6907..c4462b149d6a18ad843a392f4692f7668e964e0e 100644
--- a/Source/core/html/forms/ColorInputType.cpp
+++ b/Source/core/html/forms/ColorInputType.cpp
@@ -82,7 +82,13 @@ PassRefPtrWillBeRawPtr<InputType> ColorInputType::create(HTMLInputElement& eleme
 
 ColorInputType::~ColorInputType()
 {
-    endColorChooser();

[Mike West, 2014/10/06 18:45:32]

Why is it safe to drop this call?

[sof, 2014/10/06 19:19:29]

Sorry, should have made that clear with a review comment.

The call hasn't been dropped but pushed down to the ColorChooser finalizers. As
ColorChooser objects are also on the heap, that's where this call have to be
with Oilpan(*)..and it makes sense to (I think) to have the ColorChooser take
care of their own shutdown rather than have its owning object do it.

* Oilpan finalizers cannot touch other heap objects, as we have no finalization
ordering.

[Mike West, 2014/10/06 19:29:29]

Makes sense, thank you.

+}
+
+void ColorInputType::trace(Visitor* visitor)
+{
+    visitor->trace(m_chooser);
+    BaseClickableWithKeyInputType::trace(visitor);
+    ColorChooserClient::trace(visitor);
 }
 
 void ColorInputType::countUsage()