Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Side by Side Diff: Source/core/page/Chrome.cpp

Issue 631833002: Move color chooser objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Keep ~ColorInputType empty Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/page/Chrome.h ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2012, Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012, Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 ScopedPageLoadDeferrer deferrer; 323 ScopedPageLoadDeferrer deferrer;
324 324
325 m_client->print(frame); 325 m_client->print(frame);
326 } 326 }
327 327
328 void Chrome::enumerateChosenDirectory(FileChooser* fileChooser) 328 void Chrome::enumerateChosenDirectory(FileChooser* fileChooser)
329 { 329 {
330 m_client->enumerateChosenDirectory(fileChooser); 330 m_client->enumerateChosenDirectory(fileChooser);
331 } 331 }
332 332
333 PassOwnPtr<ColorChooser> Chrome::createColorChooser(LocalFrame* frame, ColorChoo serClient* client, const Color& initialColor) 333 PassOwnPtrWillBeRawPtr<ColorChooser> Chrome::createColorChooser(LocalFrame* fram e, ColorChooserClient* client, const Color& initialColor)
334 { 334 {
335 notifyPopupOpeningObservers(); 335 notifyPopupOpeningObservers();
336 return m_client->createColorChooser(frame, client, initialColor); 336 return m_client->createColorChooser(frame, client, initialColor);
337 } 337 }
338 338
339 PassRefPtr<DateTimeChooser> Chrome::openDateTimeChooser(DateTimeChooserClient* c lient, const DateTimeChooserParameters& parameters) 339 PassRefPtr<DateTimeChooser> Chrome::openDateTimeChooser(DateTimeChooserClient* c lient, const DateTimeChooserParameters& parameters)
340 { 340 {
341 notifyPopupOpeningObservers(); 341 notifyPopupOpeningObservers();
342 return m_client->openDateTimeChooser(client, parameters); 342 return m_client->openDateTimeChooser(client, parameters);
343 } 343 }
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 for (size_t i = 0; i < observers.size(); ++i) 402 for (size_t i = 0; i < observers.size(); ++i)
403 observers[i]->willOpenPopup(); 403 observers[i]->willOpenPopup();
404 } 404 }
405 405
406 void Chrome::willBeDestroyed() 406 void Chrome::willBeDestroyed()
407 { 407 {
408 m_client->chromeDestroyed(); 408 m_client->chromeDestroyed();
409 } 409 }
410 410
411 } // namespace blink 411 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/page/Chrome.h ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698