Move color chooser objects to the Oilpan heap.

Source/web/ColorChooserUIController.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 20 matching lines @@
 #include "public/platform/WebColor.h"
 #include "public/web/WebColorChooser.h"
 #include "public/web/WebColorSuggestion.h"
 #include "public/web/WebFrameClient.h"
 #include "web/WebLocalFrameImpl.h"
 
 namespace blink {
 
 
 ColorChooserUIController::ColorChooserUIController(LocalFrame* frame, ColorChooserClient* client)
-    : m_frame(frame)
-    , m_client(client)
+    : m_client(client)
+    , m_frame(frame)
 {
 }
 
 ColorChooserUIController::~ColorChooserUIController()
 {
+    // The client cannot be accessed when finalizing.
+    m_client = nullptr;
+    endChooser();
+}
+
+void ColorChooserUIController::trace(Visitor* visitor)
+{
+    visitor->trace(m_frame);
+    visitor->trace(m_client);
+    ColorChooser::trace(visitor);
 }
 
 void ColorChooserUIController::openUI()
 {
     openColorChooser();
 }
 
 void ColorChooserUIController::setSelectedColor(const Color& color)
 {
     ASSERT(m_chooser);
@@ skipping 12 matching lines @@
 }
 
 void ColorChooserUIController::didChooseColor(const WebColor& color)
 {
     ASSERT(m_client);
     m_client->didChooseColor(Color(static_cast<RGBA32>(color)));
 }
 
 void ColorChooserUIController::didEndChooser()
 {
     ASSERT(m_client);

[haraken, 2014/10/07 08:27:35]

I think you need to remove this ASSERT.

[sof, 2014/10/08 10:26:34]

Done.

     m_chooser = nullptr;
-    m_client->didEndChooser();
+    if (m_client)
+        m_client->didEndChooser();
 }
 
 void ColorChooserUIController::openColorChooser()
 {
     ASSERT(!m_chooser);
     WebLocalFrameImpl* frame = WebLocalFrameImpl::fromFrame(m_frame);
     WebFrameClient* webFrameClient = frame->client();
     if (!webFrameClient)
         return;
     m_chooser = adoptPtr(webFrameClient->createColorChooser(
         this, static_cast<WebColor>(m_client->currentColor().rgb()), m_client->suggestions()));
 }
 
 } // namespace blink