Move color chooser objects to the Oilpan heap.

Source/web/ColorChooserPopupUIController.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 18 matching lines @@
 #include "core/page/PagePopupClient.h"
 #include "web/ColorChooserUIController.h"
 #include "wtf/OwnPtr.h"
 
 namespace blink {
 
 class ChromeClientImpl;
 class ColorChooserClient;
 class PagePopup;
 
-class ColorChooserPopupUIController FINAL : public ColorChooserUIController, public PagePopupClient  {
+class ColorChooserPopupUIController final : public ColorChooserUIController, public PagePopupClient  {
 
 public:
-    ColorChooserPopupUIController(LocalFrame*, ChromeClientImpl*, ColorChooserClient*);
+    static PassOwnPtrWillBeRawPtr<ColorChooserPopupUIController> create(LocalFrame* frame, ChromeClientImpl* chromeClient, ColorChooserClient* client)
+    {
+        return adoptPtrWillBeNoop(new ColorChooserPopupUIController(frame, chromeClient, client));
+    }
+
     virtual ~ColorChooserPopupUIController();
+    virtual void trace(Visitor*) override;
 
     // ColorChooserUIController functions:
-    virtual void openUI() OVERRIDE;
+    virtual void openUI() override;
 
     // ColorChooser functions
-    virtual void endChooser() OVERRIDE;
-    virtual AXObject* rootAXObject() OVERRIDE;
+    virtual void endChooser() override;
+    virtual AXObject* rootAXObject() override;
 
     // PagePopupClient functions:
-    virtual IntSize contentSize() OVERRIDE;
-    virtual void writeDocument(SharedBuffer*) OVERRIDE;
-    virtual Locale& locale() OVERRIDE;
-    virtual void setValueAndClosePopup(int, const String&) OVERRIDE;
-    virtual void setValue(const String&) OVERRIDE;
-    virtual void closePopup() OVERRIDE;
-    virtual Element& ownerElement() OVERRIDE;
-    virtual void didClosePopup() OVERRIDE;
+    virtual IntSize contentSize() override;
+    virtual void writeDocument(SharedBuffer*) override;
+    virtual Locale& locale() override;
+    virtual void setValueAndClosePopup(int, const String&) override;
+    virtual void setValue(const String&) override;
+    virtual void closePopup() override;
+    virtual Element& ownerElement() override;
+    virtual void didClosePopup() override;

[Mike West, 2014/10/06 18:45:32]

C++11!1!!!1!

[sof, 2014/10/06 19:19:29]

I know there are renaming CLs coming down the chute, so not sure I ought to be
doing this (and instead rely on them to mop up.)

But it looked weird to add a use of 'override' for trace() and leave the rest
with the old school OVERRIDE.

[Mike West, 2014/10/06 19:29:29]

I agree. You should feel free to clean up as you go. Let the big, mechanical CL
writers deal with the big mechanical rebases. :)

[tkent, 2014/10/07 02:25:00]

FYI.  Our new rule is to remove |virtual| if a function has |override| or
|final|.  So, even if you replace all of |OVERRIDE| with |override| in this CL,
we need to update all of lines again to remove |virtual|.

 
 private:
+    ColorChooserPopupUIController(LocalFrame*, ChromeClientImpl*, ColorChooserClient*);
+
     void openPopup();
 
     ChromeClientImpl* m_chromeClient;
-    ColorChooserClient* m_client;
+    RawPtrWillBeMember<ColorChooserClient> m_client;
     PagePopup* m_popup;

[haraken, 2014/10/07 03:31:29]

This raw pointer looks safe since it's cleared in didClosePopup().

     Locale& m_locale;
 };
 
-}
+} // namespace blink
 
 #endif // ColorChooserPopupUIController_h